-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI-tests #157
Add UI-tests #157
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
=======================================
Coverage 41.42% 41.42%
=======================================
Files 8 8
Lines 548 548
Branches 75 75
=======================================
Hits 227 227
Misses 317 317
Partials 4 4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I left a minor comment, but we can change it on a follow-up PR.
"name": "glue-lab-ui-tests", | ||
"version": "1.0.0", | ||
"description": "JupyterLab glue-lab Integration Tests", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to change the name and description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed it.
I opened #176
This adds integration test to the package; in particular those drafted in jupyterlab/jupyterlab#13240.