Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI-tests #157

Merged
merged 16 commits into from
Jun 30, 2023
Merged

Add UI-tests #157

merged 16 commits into from
Jun 30, 2023

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Jun 2, 2023

This adds integration test to the package; in particular those drafted in jupyterlab/jupyterlab#13240.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Binder 👈 Launch a Binder on branch brichet/jupyter_collaboration/ui_tests

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b535c40) 41.42% compared to head (bfb85ab) 41.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   41.42%   41.42%           
=======================================
  Files           8        8           
  Lines         548      548           
  Branches       75       75           
=======================================
  Hits          227      227           
  Misses        317      317           
  Partials        4        4           
Impacted Files Coverage Δ
jupyter_collaboration/rooms.py 20.80% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fcollonval fcollonval marked this pull request as ready for review June 13, 2023 12:28
Copy link
Member

@hbcarlos hbcarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I left a minor comment, but we can change it on a follow-up PR.

Comment on lines +2 to +4
"name": "glue-lab-ui-tests",
"version": "1.0.0",
"description": "JupyterLab glue-lab Integration Tests",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to change the name and description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed it.
I opened #176

@hbcarlos hbcarlos merged commit ebac582 into jupyterlab:main Jun 30, 2023
@welcome
Copy link

welcome bot commented Jun 30, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@brichet brichet deleted the ui_tests branch July 3, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants