-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some notebooks fail to open #162
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
I am recently getting the same issue after installing jupyter rtc I am also hitting this warning which I tracked to the below line of code: Any idea what I am doing wrong exactly? I guess the purpose behind RTC is to be able to open the same file from different locations… |
Fixed by #157 |
Hi @aghand0ur, thank you for reporting this. In summary, you can collaborate between Notebook Editor and Notebook Editor on different clients but not between Notebook Editor and Editor (either the same client or another client). FYI, Editor is the plain text editor, and Notebook Editor is the notebook. |
thanks for the elaborative reply @hbcarlos |
The error persists with the new PR:
|
I guess we need to re-open this issue |
The package was not released yet with the fix, or have you installed a dev version of jupyter-collaboration? |
Hi, @aghand0ur. That trace doesn't correspond with the main branch.
jupyter-collaboration/jupyter_collaboration/rooms.py Lines 190 to 192 in 5c67797
|
no I installed version |
If you absolutely want the fix today yes. Otherwise you could wait for a release to be made. |
any idea when is the planned coming release? |
This issue is still present in 1.1.0 I only ever open the notebooks via double clicking from the file browser menu. I assume this is the notebook editor. There also seems to be no way to track where and how the files are opened, such as a session management feature? In my experience, I open a notebook make some changes, navigate away from the server site and come back some time later and start receiving these errors. |
I also come across exactly this error quite regularly. Running Jupyter via the docker [E 2023-09-21 14:25:51.400 YDocExtension] Error watching file: debug.ipynb
TypeError("'<' not supported between instances of 'NoneType' and 'datetime.datetime'")
Traceback (most recent call last):
File "/opt/conda/lib/python3.11/site-packages/jupyter_collaboration/loaders.py", line 170, in _watch_file
await self.notify()
File "/opt/conda/lib/python3.11/site-packages/jupyter_collaboration/loaders.py", line 187, in notify
await callback("metadata", model)
File "/opt/conda/lib/python3.11/site-packages/jupyter_collaboration/rooms.py", line 190, in _on_content_change
if event == "metadata" and self._last_modified < args["last_modified"]:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: '<' not supported between instances of 'NoneType' and 'datetime.datetime' |
I hit this issue as well with Fwiw monkey-patching rooms.py single line to:
Fixed it for me until main branch has a new release. |
@martinRenou @hbcarlos shall this issue be re-opened? |
Both wheel and source distributions uploaded to PyPI contain the problematic line rather than what is there on the |
Well, I guess not - this was just not backported to 1.x branch:
|
I see this too after installing
If I disable RTC by adding In case it's relevant, this is in a Docker image based on |
Hi, @aghand0ur and @nwalters512. There is a new pre-release with a fix for this issue. Could you check whether this issue persists with the new v2.0.0-alpha.1? You can install the new pre-release in a new environment with:
|
@hbcarlos |
@hbcarlos,
|
This issue should be reopened and a fix should be provided for 1.x and 2.x. I'm looking into making a PR. |
Actually it is fixed in 2.x but not backported. |
And 2.x is not merged, right? |
Sorry I did not mean the 2.x branch but the 2.x releases |
We should probably reset the 2.x branch to main to remove this confusion |
What do you mean by "reset"? I think |
Then "renamed" and not "reset". |
Maybe yes, what about renaming |
Done: 3.x. |
does the new 2.0.1 release cover this issue? |
Yes, it should be fixed since v2.0.0. |
Right but another issue popped-up as outlined here: |
I opened #229. |
This issue seems to be happening for some files as well only with RTC
whenever I open with RTC: Here is the log
2024-03-17.18-52-35.mp4These files were working before in RTC so not sure what caused them to stop working but the
then it works, for anyone looking for a fix |
I get this error even when only opening the notebook, if I create a copy of the notebook then it will show an encoded version instead of the notebook (second video) 2024-03-18.11-41-14.mp42024-03-18.11-44-54.mp4Binary diff of the files show they are the exact same, so there must be something with some caching |
Update: After restarting the error is back again..... I checked the file and the nbformat is still 4 and nbformat_minor still 5, so there is something else causing this issue, the re-saving is only a temporary fix for the life that you have the server open, just duplicating the file makes the new one work but not the old one, so some problem with caching |
Still getting this on,
When I opened a notebook (
Best, |
Hey all, I am observing the same. I am also running on 2.0.11. Is there any solution for this? Is this fixed by 2.1.0? |
I post this here in case someone has a similar problem and might be related My storage was full, therefore notebooks were not opening. But because I was receiving the message I am still receiving the error message, but clearing cache allowed me to open notebooks (I saw that in cache there was a huge hugging face model from a previous notebook) |
Description
Notebook loads forever and the log gets spammed with:
The text was updated successfully, but these errors were encountered: