Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up #133 #136

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Follow up #133 #136

merged 1 commit into from
Mar 31, 2023

Conversation

hbcarlos
Copy link
Member

  • Could you raise an error in registerDocumentFactory if there is already an factory for the content type?
  • Could you correct the doc string for the plugins? It will be also good to define the new description attribute of the application plugin

Review by @fcollonval

@hbcarlos hbcarlos added the enhancement New feature or request label Mar 30, 2023
@hbcarlos hbcarlos requested a review from fcollonval March 30, 2023 15:00
@hbcarlos hbcarlos self-assigned this Mar 30, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch hbcarlos/jupyter_collaboration/follow_up#133

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (612c443) 0.00% compared to head (95c365a) 0.00%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #136   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          3       3           
  Lines        297     297           
=====================================
  Misses       297     297           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

@fcollonval fcollonval merged commit eb8456d into jupyterlab:main Mar 31, 2023
@hbcarlos hbcarlos deleted the follow_up#133 branch March 31, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants