Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow other extensions to register shared models #133

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Allow other extensions to register shared models #133

merged 2 commits into from
Mar 29, 2023

Conversation

hbcarlos
Copy link
Member

Fixes JupyterCAD and Glue-lab

cc @trungleduc @martinRenou

@hbcarlos hbcarlos added the enhancement New feature or request label Mar 28, 2023
@hbcarlos hbcarlos self-assigned this Mar 28, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch hbcarlos/jupyter_collaboration/rtc_registry

@trungleduc
Copy link
Member

Why do we accept only the string file format here? https://github.com/jupyterlab/jupyter_collaboration/blob/2432fe032cce3414836ef035fe975acb1fcd8655/packages/docprovider/src/ydrive.ts#L201-L203

@hbcarlos
Copy link
Member Author

Because the file format can be null and we need it to create the room id in the document provider. See https://github.com/jupyterlab/jupyter_collaboration/blob/2432fe032cce3414836ef035fe975acb1fcd8655/packages/docprovider/src/ydrive.ts#L124

@trungleduc
Copy link
Member

JupyterCad defines the FCStd file format as base64, it will work here?

@hbcarlos
Copy link
Member Author

JupyterCad defines the FCStd file format as base64, it will work here?

Yes. We are checking the attribute type (typeof options.format), not the attribute itself.

@hbcarlos hbcarlos merged commit 26ff6c7 into jupyterlab:main Mar 29, 2023
@hbcarlos hbcarlos deleted the rtc_registry branch March 29, 2023 07:21
hbcarlos added a commit to hbcarlos/jupyter-collaboration that referenced this pull request Mar 30, 2023
@hbcarlos
Follow up jupyterlab#133
95c365a
fcollonval pushed a commit that referenced this pull request Mar 31, 2023
@hbcarlos
Follow up #133 (#136)
eb8456d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbrochart davidbrochart davidbrochart approved these changes

@trungleduc trungleduc trungleduc approved these changes

@fcollonval fcollonval Awaiting requested review from fcollonval

Assignees

@hbcarlos hbcarlos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbcarlos @trungleduc @davidbrochart