CI: stop asserting local binderhub version match remote version #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to add a modified version of this assertion back. The test didn't mean to check that the versions were the same but that the version appears in the page. I think using the local version was an easy way to check that the expected text appears. A bit more tricky to do if we don't know what version will appear but it would be good to keep testing that a vresion is displayed. |
|
I agree @betatim, i felt i overstepped, and added it back in https://github.com/jupyterhub/binderhub/pull/1203/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1200 by no longer asserting the remote test environment will have the binderhub version according to versioneer which use git commits to decide its version, compared to the built image.
The image would rebuild if binderhub the Python package had changed at all, but it wouldn't if something unrelated has been committed. The _version.py script doesn't care about this though, and decides the binderhub package is even newer than the image and observes a version mismatch.
Due to this, I suggest we stop asserting this. I don't see this assertion to be helpful to make unless we tighten down the test to only be relevant in a few cases, and that doesn't seem to be helpful enough to motivate it. Due to this, I'll go ahead and remove this assertion from the /about test.