Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failures of the Helm chart diagnosed along with an easy fix #1200

Closed
consideRatio opened this issue Nov 3, 2020 · 0 comments · Fixed by #1201
Closed

Test failures of the Helm chart diagnosed along with an easy fix #1200

consideRatio opened this issue Nov 3, 2020 · 0 comments · Fixed by #1201

Comments

@consideRatio
Copy link
Member

Following #1188 we are not longer always rebuilding our docker images for the Helm chart. Due to this, we run into this error.

=================================== FAILURES ===================================
______________________________ test_about_handler ______________________________
app = <binderhub.tests.conftest.RemoteBinderHub object at 0x7f7e74491730>
    @pytest.mark.remote
    async def test_about_handler(app):
        # Check that the about page loads
        r = await async_requests.get(app.url + "/about")
        assert r.status_code == 200
        assert "This website is powered by" in r.text
>       assert binder_version in r.text
E       assert '0.2.0+354.g83ad58e.dirty' in '<!DOCTYPE html>\n<html>\n<head>\n  <title>Binder</title>\n  \n<meta property="og:description" content="Reproducible, ...        \n        </div>\n      </div>\n      \n    </div>\n  </div>\n</div>\n\n\n  \n\n\n  \n  \n  \n</body>\n</html>'
E        +  where '<!DOCTYPE html>\n<html>\n<head>\n  <title>Binder</title>\n  \n<meta property="og:description" content="Reproducible, ...        \n        </div>\n      </div>\n      \n    </div>\n  </div>\n</div>\n\n\n  \n\n\n  \n  \n  \n</body>\n</html>' = <Response [200]>.text

This is caused by the test_environment being out of sync with the built image. I that we remove the version match assertion as a resolution as the other part of the test is still relevant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: stop asserting local binderhub version match remote version consideRatio/binderhub
1 participant
@consideRatio