-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI / Local dev refresh and Helm2->3 transition #1188
Conversation
This was used by pytest-tornado, but we have transitioned away to use pytest-asyncio instead where it is not longer a supported configuration. See JupyterHub PR 2812 for more detail.
eb05ca9
to
c71b52b
Compare
eca9320
to
d4847ed
Compare
4e498b7
to
9665399
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this work @consideRatio! ✨ I have just left a few comments but this looks good to me :)
Co-authored-by: Sarah Gibson <44771837+sgibson91@users.noreply.github.com>
84e8c83
to
3bb3eff
Compare
@sgibson91 ❤️ 🎉 thank you for the review!! |
I am not looking to many any more changes to this PR at this point, and it is ready for a final review. Merging this gives us faster CI + faster upgrades by not replacing the docker image as often for no reason. |
Looks nice. Thanks! |
With a easy to understand CI system without tangled configuration that influence too many things at once, I hope that it will help myself and others to make contributions to this project in the long term. I wanted to update this step by step towards being easier to understand, maintain, and update it with tricks learned over time.
Work to be done
Review notes
minikube
and I have not introduced new tooling (except the helm v2 to v3 migration).Positive outcomes
helm3 template --validate
both renders the templates but also validates them as valid k8s resources against a k8s api-server. It is a more heavy weight option to usingkubeval
and such tools as it requires a k8s api-server to speak with.