WIP - some changes to the serializers. #1300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The get_state changes are incorporated in #1302. |
|
I just rebased keeping the relevant changes from before. |
| } | ||
| } catch (e) { | ||
| console.error("Error serializing widget state attribute: ", k); | ||
| console.error(`Error serializing widget state attribute ${k} (value ${state[k]})`); | ||
| throw e; |
There was a problem hiding this comment.
I believe IE doesnt support this, right @SylvainCorlay, what's it called, template strings orso?
There was a problem hiding this comment.
typescript compiles this down to normal js strings.
There was a problem hiding this comment.
jasongrout
added a commit
to jasongrout/ipywidgets
that referenced
this pull request
May 17, 2017
…a second argument, not the widget manager. We had not been calling the static _serialize_state method, and there was ambiguity with what the second argument was. This incorporates the last part of jupyter-widgets#1300.
|
Closed in favor of #1355, which has the last part of the above. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally part of #1294, and was reverted in c64e5f6