Make the output widget store its state. #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we should just store the *initial* state, and forever after ignore that variable.
We should check that this is still compatible with Notebook 4.4.1
We’ll get these in a different PR.
|
@SylvainCorlay - I think this is ready for review. Refreshing a page with an output widget now works. The output messages should be stored when saving the widget state as well. Unfortunately, it means that we have to double-transfer any output (once as a display_data message, another time as the output widget state). |
jasongrout
added a commit
to jasongrout/ipywidgets
that referenced
this pull request
Apr 18, 2017
This was originally part of jupyter-widgets#1294, and was reverted in c64e5f6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work on #986.