Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change isapprox(a,b) to a \approx b in tests #2419

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

mikerouleau
Copy link
Contributor

@mikerouleau mikerouleau commented Jan 1, 2021

I found a TODO note in /test/nlp.jl indicating this should be done (probably because it's cleaner), so I worked on the low-hanging fruit.

Not related to any open issues (that I'm aware of).

@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #2419 (9eacdea) into master (2b0d910) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2419   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files          43       43           
  Lines        4614     4614           
=======================================
  Hits         4257     4257           
  Misses        357      357           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b0d910...9eacdea. Read the comment docs.

@mikerouleau mikerouleau marked this pull request as ready for review January 1, 2021 21:29
@odow
Copy link
Member

odow commented Jan 4, 2021

Thanks @mikerouleau. I'll merge this since you took the effort to make the changes. (It looks like you ran the formatter as well! I'm still in the process of rolling it out.)

If you find other TODOs in the source, and can't find a corresponding issue, please open one so we can discuss what to do.

If you have time, and are interested in contributing to JuMP, you can take a look at the issues marked "Help wanted": https://github.com/jump-dev/JuMP.jl/labels/help%20wanted

Here's a good one to get started with: #2371

@odow odow merged commit b562ae8 into jump-dev:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants