Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest I-D: 1.0 and 1.1e1 are integers #135

Closed
awwright opened this issue Nov 21, 2016 · 5 comments
Closed

Latest I-D: 1.0 and 1.1e1 are integers #135

awwright opened this issue Nov 21, 2016 · 5 comments
Labels
missing test A request to add a test to the suite that is currently not covered elsewhere.
Milestone
draft 5

Comments

@awwright
Copy link
Member

The new draft-05 suite should ensure that values like 1.0 and 1.1e1 are integers.

As resolved in #132
@awwright awwright added the bug A test is wrong, or tooling is broken or buggy. label Nov 21, 2016
@Relequestual Relequestual added this to the draft 6 milestone Nov 21, 2016
@Relequestual
Copy link
Member

Calling an unwritten test a bug seems a bit unfair. Each draft has its own set of tests.

@awwright awwright added missing test A request to add a test to the suite that is currently not covered elsewhere. and removed bug A test is wrong, or tooling is broken or buggy. labels Nov 22, 2016
@epoberezkin
Copy link
Member

closed by #164?

@awwright
Copy link
Member Author

awwright commented Mar 2, 2017 via email

@epoberezkin
Copy link
Member

Yes, the description doesn't make sense...

"some languages do not distinguish between different types of numeric value" -> can stay the same?
"a float is not an integer even without fractional part" -> "a float without fractional part is an integer"

@handrews @awwright ok?

@epoberezkin epoberezkin mentioned this issue Mar 12, 2017
Closed
14 tasks
@awwright
Copy link
Member Author

"a float without fractional part is an integer" seems really weird (since we're distinguishing two kinds of floats) but I can't think of anything better. Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
missing test A request to add a test to the suite that is currently not covered elsewhere.
Projects
None yet
Milestone
draft 5
Development

No branches or pull requests
3 participants
@awwright @Relequestual @epoberezkin