Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft-06 tests checklist #153

Closed
14 tasks done
epoberezkin opened this issue Jan 26, 2017 · 9 comments
Closed
14 tasks done

draft-06 tests checklist #153

epoberezkin opened this issue Jan 26, 2017 · 9 comments

Comments

@epoberezkin
Copy link
Member

epoberezkin commented Jan 26, 2017

@epoberezkin epoberezkin changed the title Update draft-06 tests draft-06 tests checklist Jan 26, 2017
@epoberezkin
Copy link
Member Author

@awwright @handrews @Relequestual @Julian
#157, #158 are approved - please merge
Please review #151, #154, #159

@Julian
Copy link
Member

Julian commented Feb 12, 2017

@epoberezkin you've now got merge rights, sorry, didn't notice before.

Enjoy.

Will try to have a look at some of the outstanding stuff there.

@epoberezkin
Copy link
Member Author

@Julian thank you. I won't merge things before they are reviewed and approved anyway.

@epoberezkin
Copy link
Member Author

@handrews @Relequestual @awwright @Julian could you please review PRs #171, #172, #173

@Julian
Copy link
Member

Julian commented Mar 12, 2017

Already did :).

Will have a look at the new one.

@Julian
Copy link
Member

Julian commented Mar 26, 2017

Do we have a permanent URL for the metaschema now? Some authors (at least me :) won't cut a release until such a thing is in place. Maybe that's a better blocker for the spec repo than here though.

@handrews
Copy link
Contributor

Do we know the URL? Yes. Have we actually put it there? Well...
json-schema-org/json-schema-spec#265
For whatever reason, awwright absolutely refuses to do it except at the time that he submits the draft.

@Julian
Copy link
Member

Julian commented Mar 26, 2017

Ah, I see.

Fair enough. It does look like at least that http://json-schema.org/draft-06/schema resolves to something already.

Carry on then :)

@handrews
Copy link
Contributor

Oh yeah, I forgot we did that. It's just the actual link in the draft on master that awwright refuses to allow anyone to touch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants