Add --config-override feature
#1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o lockfile-merge
delete config_override step unify step description syntax
|
@sriniv27 Hi! I see that you requested review, but there are still commits happening, and activity in the related issue. Is this ready for review? It's fine either way, I just didn't want to comment on things if you're still working on them. |
|
I've only been making commits here to directly address review comments and smaller housekeeping things. I'd call this ready for review. |
micahellison
requested changes
Feb 27, 2021
features/overrides.feature
Outdated
| When we run jrnl with -1 --config-override colors.body blue | ||
| Then the runtime config should have colors.body set to blue | ||
|
|
||
| @skip_win |
There was a problem hiding this comment.
I created #1200 to troubleshoot, but it looks like all these passed in the CI this time. Could you try removing them and confirming?
wren
requested changes
Feb 27, 2021
6 tasks
yield -> return remove needless copy adjust spacing re-inline args return reset packaging info to e6c0a16 revert package version for this PR
store cli overrides without unpacking just yet
move deserialize_config_args to config module
delete custom Action class for config operations
apply [k,v] -> {k, v} for each override
update test data
update import
sriniv27
commented
Mar 1, 2021
|
Awesome! I'll take a look again tonight. |
--config-override feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jrnlby way of a delimited list of key-value pairs. The keys can be provided in dot-notation form e.g.colors.bodyOverride (select) configuration values during invocation #1157
I would like to run jrnl with different configurations for some specific workflows but still maintain my current configuration for "normal" writing workflows.
For example:
code -was my editor. For rapid logging, I want to be able open a terminal and be dropped into the stdin prompt, record my thought, and Ctrl+D out.linewrapvalue than the defaultSee motivating comment
jrnl -on today --config-override editor '' --config-override journals.log "~/logfile.txt"jrnl -on today --config-override linewrap 30 --config-override highlight false --config-override display_format fancyChecklist
for the same issue.