Fix bug that prevented --format pretty and --format short from working #1177

sriniv27 · 2021-02-04T17:31:45Z

This code attempts to fix a bug as described in #1172 and #1173 where --format pretty as well as --format short returned an error. This is inconsistent with the documentation on the Formats page: https://jrnl.sh/en/stable/formats/

~~To implement this, a very thin PrettyExporter was created, inheriting from TextExporter, and forwards export_entry to Entry.pprint.~~

~~To gracefully handle this and some modifications for color handling needed to be made.~~

Checklist

I have read the contributing doc.
I have included a link to the relevant issue number.
I have tested this code locally.
I have checked to ensure there aren't other open pull requests
for the same issue.
I have written new tests for these changes, as needed.
All tests pass.

wren

I think the fix can be much smaller than this.

The function _display_search_results in jrnl/jrnl.py (at the bottom) has some handling for displaying formats. --format short and --format pretty should be aliases for print(journal.pprint(short=True)) and print(journal.pprint(short=True)) respectively. Those options are already in the function under other names, so changes could be limited to a few lines in that function (plus associated tests, of course).

Sorry, this looks like it was a lot of work, but it's a bit too much for this particular fix.

This reverts commit ddb62b7.

This reverts commit ce930a2.

This reverts commit 3d69131.

This reverts commit cc9a2f1.

sriniv27 · 2021-02-07T02:40:48Z

No problem at all! Just a matter of rewinding a few commits; already had an acceptance test that needed to pass.

To enable the _display_search_results implementation, I needed to append __exporter_types with dummy kvpairs {short:None} and {pretty: None} so argparse wouldn't complain. Let me know if this isn't ideal and I will look at another approach.

sriniv27 · 2021-02-25T12:00:35Z

Is there anything blocking this from being reviewed?

wren · 2021-02-25T20:24:01Z

Is there anything blocking this from being reviewed?

Nope, you're good. @micahellison and I will review it on Saturday during our regular session.

Sorry we didn't review last week! We didn't think it was ready, but will definitely get to it this week.

sriniv27 · 2021-02-25T23:28:55Z

Np, thank you for clarifying

micahellison

Thanks for the PR! Just a few small comments/changes.

.vscode/launch.json

features/steps/core.py

tests/test_color.py

tests/test_display.py

wren

Looking good! A few comments inline.

Sorry again for the delay, and please request another review when this is ready.

.gitignore

features/format.feature

features/data/configs/pretty.yaml

features/steps/export_steps.py

jrnl/jrnl.py

tests/test_display.py

make the test perform actual qualification make format update other test as well remove unnecessary mock reset .gitignore to e6c0a16 delete pretty.yaml remove launch.json reorder mocks convert scenario to scenario outline for behavioral coverage fix scenario syntax comment out problematic step; add password handling reorder import meld conditional code rework melded export logic update code to be exercised in test

jrnl/jrnl.py

micahellison

Looks good to go. One small change then it will be ready (patch below)

Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>

micahellison

Looks great! Thank you for your work on this.

wren

Thank you!

Add pypi links for documentation, issue tracking, and funding (jrnl-org#1204) Update changelog [ci skip] Fix bug that prevented --format pretty and --format short from working (jrnl-org#1177) Update changelog [ci skip] Fix broken brew release process (jrnl-org#1211) * Add homebrew symlink for releases * Fix indentation problem * Fix bad env var name * Change filename to formula name * Fix formula name * Attempt tap instead of symlink * Fix formula repo referece * add tracer * Attempt working directory fix * Remove --unshallow * Use token for remote * Move set tap directory step * Remove tracer * Clean up spacing and wrap quotes to tap directory Remove global flag from git config Add --local flag in git config calls Increment version to v2.7.2-beta Bump keyring from 22.3.0 to 23.0.0 (jrnl-org#1213) Bumps [keyring](https://github.com/jaraco/keyring) from 22.3.0 to 23.0.0. - [Release notes](https://github.com/jaraco/keyring/releases) - [Changelog](https://github.com/jaraco/keyring/blob/main/CHANGES.rst) - [Commits](jaraco/keyring@v22.3.0...v23.0.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Increment version to v2.8-beta Changelog generator fixes There were several problems that this fixes: - shallow fetch broke merging to release branch - bad changelog was only outputting error msg (not exiting) - latest version being on first line deleted itself and broke the changelog updates This also has manual fixes to the changelog to bring it up to date. Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com> Bump pyflakes from 2.2.0 to 2.3.0 (jrnl-org#1215) Bumps [pyflakes](https://github.com/PyCQA/pyflakes) from 2.2.0 to 2.3.0. - [Release notes](https://github.com/PyCQA/pyflakes/releases) - [Changelog](https://github.com/PyCQA/pyflakes/blob/master/NEWS.rst) - [Commits](PyCQA/pyflakes@2.2.0...2.3.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Change PR steps for brew release The hub cli tool wasn't working anymore, so we took it out. Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com> Update changelog [ci skip]

Add pypi links for documentation, issue tracking, and funding (jrnl-org#1204) Update changelog [ci skip] Fix bug that prevented --format pretty and --format short from working (jrnl-org#1177) Update changelog [ci skip] Fix broken brew release process (jrnl-org#1211) * Add homebrew symlink for releases * Fix indentation problem * Fix bad env var name * Change filename to formula name * Fix formula name * Attempt tap instead of symlink * Fix formula repo referece * add tracer * Attempt working directory fix * Remove --unshallow * Use token for remote * Move set tap directory step * Remove tracer * Clean up spacing and wrap quotes to tap directory Remove global flag from git config Add --local flag in git config calls Increment version to v2.7.2-beta Bump keyring from 22.3.0 to 23.0.0 (jrnl-org#1213) Bumps [keyring](https://github.com/jaraco/keyring) from 22.3.0 to 23.0.0. - [Release notes](https://github.com/jaraco/keyring/releases) - [Changelog](https://github.com/jaraco/keyring/blob/main/CHANGES.rst) - [Commits](jaraco/keyring@v22.3.0...v23.0.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Increment version to v2.8-beta Changelog generator fixes There were several problems that this fixes: - shallow fetch broke merging to release branch - bad changelog was only outputting error msg (not exiting) - latest version being on first line deleted itself and broke the changelog updates This also has manual fixes to the changelog to bring it up to date. Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com> Bump pyflakes from 2.2.0 to 2.3.0 (jrnl-org#1215) Bumps [pyflakes](https://github.com/PyCQA/pyflakes) from 2.2.0 to 2.3.0. - [Release notes](https://github.com/PyCQA/pyflakes/releases) - [Changelog](https://github.com/PyCQA/pyflakes/blob/master/NEWS.rst) - [Commits](PyCQA/pyflakes@2.2.0...2.3.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Change PR steps for brew release The hub cli tool wasn't working anymore, so we took it out. Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com> Update changelog [ci skip] Bump cryptography from 3.4.6 to 3.4.7 (#28) Bumps [cryptography](https://github.com/pyca/cryptography) from 3.4.6 to 3.4.7. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@3.4.6...3.4.7) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump keyring from 22.3.0 to 23.0.1 (#27) Bumps [keyring](https://github.com/jaraco/keyring) from 22.3.0 to 23.0.1. - [Release notes](https://github.com/jaraco/keyring/releases) - [Changelog](https://github.com/jaraco/keyring/blob/main/CHANGES.rst) - [Commits](jaraco/keyring@v22.3.0...v23.0.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump pyflakes from 2.2.0 to 2.3.1 (#26) Bumps [pyflakes](https://github.com/PyCQA/pyflakes) from 2.2.0 to 2.3.1. - [Release notes](https://github.com/PyCQA/pyflakes/releases) - [Changelog](https://github.com/PyCQA/pyflakes/blob/master/NEWS.rst) - [Commits](PyCQA/pyflakes@2.2.0...2.3.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

FIrst pass at allow external plugins remove template exporter Add listing of active plugins to '--version' output Documentation for plugins [Docs] add custom imports and exporters to site TOC [Docs] better linewrapping Include dates_exporter Use Base classes for importer and exporters. [Docs] improve documentation of custom Importers and Exporters [Testing] separate run with external plugin! Bump keyring from 22.3.0 to 23.0.0 (jrnl-org#1213) Bumps [keyring](https://github.com/jaraco/keyring) from 22.3.0 to 23.0.0. - [Release notes](https://github.com/jaraco/keyring/releases) - [Changelog](https://github.com/jaraco/keyring/blob/main/CHANGES.rst) - [Commits](jaraco/keyring@v22.3.0...v23.0.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Increment version to v2.8-beta Changelog generator fixes There were several problems that this fixes: - shallow fetch broke merging to release branch - bad changelog was only outputting error msg (not exiting) - latest version being on first line deleted itself and broke the changelog updates This also has manual fixes to the changelog to bring it up to date. Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com> Bump pyflakes from 2.2.0 to 2.3.0 (jrnl-org#1215) Bumps [pyflakes](https://github.com/PyCQA/pyflakes) from 2.2.0 to 2.3.0. - [Release notes](https://github.com/PyCQA/pyflakes/releases) - [Changelog](https://github.com/PyCQA/pyflakes/blob/master/NEWS.rst) - [Commits](PyCQA/pyflakes@2.2.0...2.3.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Change PR steps for brew release The hub cli tool wasn't working anymore, so we took it out. Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com> Update changelog [ci skip] Increment version to v2.8 Update changelog [ci skip] Update brew tap for release pipeline This was left out of a previous commit. Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com> Docs: Add emacs as external editor to recipes (jrnl-org#1220) Add emacs as external editor to recipes Bump cryptography from 3.4.6 to 3.4.7 (jrnl-org#1223) Bumps [cryptography](https://github.com/pyca/cryptography) from 3.4.6 to 3.4.7. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@3.4.6...3.4.7) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Update changelog [ci skip] Bump pyflakes from 2.3.0 to 2.3.1 (jrnl-org#1221) Bumps [pyflakes](https://github.com/PyCQA/pyflakes) from 2.3.0 to 2.3.1. - [Release notes](https://github.com/PyCQA/pyflakes/releases) - [Changelog](https://github.com/PyCQA/pyflakes/blob/master/NEWS.rst) - [Commits](PyCQA/pyflakes@2.3.0...2.3.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump keyring from 23.0.0 to 23.0.1 (jrnl-org#1222) Bumps [keyring](https://github.com/jaraco/keyring) from 23.0.0 to 23.0.1. - [Release notes](https://github.com/jaraco/keyring/releases) - [Changelog](https://github.com/jaraco/keyring/blob/main/CHANGES.rst) - [Commits](jaraco/keyring@v23.0.0...v23.0.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump pytest from 6.2.2 to 6.2.3 (jrnl-org#1228) Bumps [pytest](https://github.com/pytest-dev/pytest) from 6.2.2 to 6.2.3. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@6.2.2...6.2.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Update changelog [ci skip] Update changelog [ci skip] More graceful handling of low linewrap values (jrnl-org#1219) * behavior outline * enforce positive initial linewrap Check column widths update gitignore throw error when linewrap too small simply check for large enough linewrap value * delete unused error message * PR feedback make exception more informative update check_linewrap signature in src and test make check_linewrap a free function * delete unused function * delete else..pass block * newline for make format Update changelog [ci skip] merge from upstream Add pypi links for documentation, issue tracking, and funding (jrnl-org#1204) Update changelog [ci skip] Fix bug that prevented --format pretty and --format short from working (jrnl-org#1177) Update changelog [ci skip] Fix broken brew release process (jrnl-org#1211) * Add homebrew symlink for releases * Fix indentation problem * Fix bad env var name * Change filename to formula name * Fix formula name * Attempt tap instead of symlink * Fix formula repo referece * add tracer * Attempt working directory fix * Remove --unshallow * Use token for remote * Move set tap directory step * Remove tracer * Clean up spacing and wrap quotes to tap directory Remove global flag from git config Add --local flag in git config calls Increment version to v2.7.2-beta Bump keyring from 22.3.0 to 23.0.0 (jrnl-org#1213) Bumps [keyring](https://github.com/jaraco/keyring) from 22.3.0 to 23.0.0. - [Release notes](https://github.com/jaraco/keyring/releases) - [Changelog](https://github.com/jaraco/keyring/blob/main/CHANGES.rst) - [Commits](jaraco/keyring@v22.3.0...v23.0.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Increment version to v2.8-beta Changelog generator fixes There were several problems that this fixes: - shallow fetch broke merging to release branch - bad changelog was only outputting error msg (not exiting) - latest version being on first line deleted itself and broke the changelog updates This also has manual fixes to the changelog to bring it up to date. Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com> Bump pyflakes from 2.2.0 to 2.3.0 (jrnl-org#1215) Bumps [pyflakes](https://github.com/PyCQA/pyflakes) from 2.2.0 to 2.3.0. - [Release notes](https://github.com/PyCQA/pyflakes/releases) - [Changelog](https://github.com/PyCQA/pyflakes/blob/master/NEWS.rst) - [Commits](PyCQA/pyflakes@2.2.0...2.3.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Change PR steps for brew release The hub cli tool wasn't working anymore, so we took it out. Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com> Update changelog [ci skip] Bump cryptography from 3.4.6 to 3.4.7 (#28) Bumps [cryptography](https://github.com/pyca/cryptography) from 3.4.6 to 3.4.7. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@3.4.6...3.4.7) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump keyring from 22.3.0 to 23.0.1 (#27) Bumps [keyring](https://github.com/jaraco/keyring) from 22.3.0 to 23.0.1. - [Release notes](https://github.com/jaraco/keyring/releases) - [Changelog](https://github.com/jaraco/keyring/blob/main/CHANGES.rst) - [Commits](jaraco/keyring@v22.3.0...v23.0.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump pyflakes from 2.2.0 to 2.3.1 (#26) Bumps [pyflakes](https://github.com/PyCQA/pyflakes) from 2.2.0 to 2.3.1. - [Release notes](https://github.com/PyCQA/pyflakes/releases) - [Changelog](https://github.com/PyCQA/pyflakes/blob/master/NEWS.rst) - [Commits](PyCQA/pyflakes@2.2.0...2.3.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

further to jrnl-org#1177

* behavior outline * FIrst pass at allow external plugins * remove template exporter * Add listing of active plugins to '--version' output * Documentation for plugins * [Docs] add custom imports and exporters to site TOC * [Docs] better linewrapping * enforce positive initial linewrap Check column widths update gitignore throw error when linewrap too small simply check for large enough linewrap value * delete unused error message * PR feedback make exception more informative update check_linewrap signature in src and test make check_linewrap a free function * delete unused function * delete else..pass block * newline for make format * Include dates_exporter * Use Base classes for importer and exporters. * [Docs] improve documentation of custom Importers and Exporters * [Testing] separate run with external plugin! * basic behavior test * prototype unittest for JSON Exporter test for unimplemented method * make format delete unused imports * Remove 'importer' or 'exporter' from filenames where not needed * [Test] run different tests with or without the external plugins installed * [Test] move test rot13 plugin into git tree from MinchinWeb/jrnl-rot13-exporter@0dc912a * consolidate demo plugins to common package * [Docs] name page for plugins * [Docs] include the sample plug in code files directly * style fixes * [test] determine whether to run external plug in tests based on installed packages * improved code documentation * style fixes for GitHub actions * Convert "short" and "pretty" (and "default") formaters to plugins further to #1177 * more code clean up tests pass locally...now for GitHub... * [tests] dynamically determine jrnl version for plugin tests * [GitHub Actions] direct install of testing plugins * Remove template code * [plugins] meta --> collector * [Docs] create scripted entries using an custom importer * (closer to) being able to run behave tests outside project root directory * We already know when exporter to use Don't re-calculate it! * [Tests] don't name test plugin 'testing" If so named, pip won't install it. * [Test] run behave tests with test plugins outside project root * [Test] behave tests pass locally * [Docs] fix typo * [GitHub Actions] run test commands from poetry's shell * black-ify code * [GitHub Actions] move downstream (rather than up) to run tests * [GitHub Actions] set shell to poetry * [GitHub Workflows] Manually activate virtual environment * [GitHub Actions] Skip Windows & Python 3.8 Can't seem to find Python exe? * [GiotHub Actions] explicitly use virtual env * [GitHub Actions] create virutal env directly * [GitHub Actions] better activate of Windows virtual env * [GitHub Actions] create virtual env on Mac * [Github Actions] install wheel and upgrade pip * [GitHub Actions] skip virtual environments altogether * [GitHub Actions] change directory for behave test * Remove Windows exclusions from CI as per note -- they should be working now Co-authored-by: Suhas <sugas182@gmail.com> Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>

sriniv27 added 13 commits February 2, 2021 20:14

behavior test for format --pretty

1f8351a

add pretty exporter

d44a6e8

include vscode debugging config

2251cd3

config file for pretty formatting

3d69131

update gitignore

bfb975b

basic colorize unittest

1739cee

implement behave test steps for format --pretty

15efc56

make color handling more robust

ce930a2

rework core run() so config_upgrade can be tested

c9404d0

formatting for pretty exporter

be8c48d

base .vscode/launch.json and ignore further user modifications from SCM

ca45c76

fix linting errors

b8daeec

make format

ddb62b7

sriniv27 marked this pull request as ready for review February 4, 2021 17:33

wren requested changes Feb 6, 2021

View reviewed changes

sriniv27 added 14 commits February 6, 2021 18:55

Revert "make format"

457375d

This reverts commit ddb62b7.

Revert "make color handling more robust"

166ca60

This reverts commit ce930a2.

Revert "config file for pretty formatting"

cc9a2f1

This reverts commit 3d69131.

delete prettyexporter

afc48bb

Revert "Revert "config file for pretty formatting""

06f5ef3

This reverts commit cc9a2f1.

delete remaining unneded code

1bd5931

define dummy exporter type pretty

6e3574c

first cut at wrapper method to export journals

2642cde

match indentation to rest of file

ddebb67

behave test and dummy short exporter

ac0233a

unittest export_journal

694ba3b

update unittest

9d60911

make format

e0f7736

fix bad mock import

9b2633a

address formatting

edc8cd9

micahellison requested changes Feb 27, 2021

View reviewed changes

.vscode/launch.json Outdated Show resolved Hide resolved

features/steps/core.py Outdated Show resolved Hide resolved

tests/test_color.py Show resolved Hide resolved

tests/test_color.py Show resolved Hide resolved

tests/test_display.py Outdated Show resolved Hide resolved

wren requested changes Feb 27, 2021

View reviewed changes

sriniv27 requested a review from wren February 28, 2021 02:20

micahellison reviewed Mar 3, 2021

View reviewed changes

jrnl/jrnl.py Outdated Show resolved Hide resolved

micahellison reviewed Mar 3, 2021

View reviewed changes

jrnl/jrnl.py Outdated Show resolved Hide resolved

micahellison requested changes Mar 3, 2021

View reviewed changes

sriniv27 and others added 3 commits March 3, 2021 07:59

Update jrnl/jrnl.py with suggestion

b1adedb

Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>

update tests and imports for removal of _export_journal

77ac858

Update core.py

8256414

sriniv27 requested a review from micahellison March 3, 2021 13:30

This was linked to issues Mar 6, 2021

jrnl --format pretty returns an error #1172

Closed

jrnl --format short returns an error #1173

Closed

micahellison approved these changes Mar 6, 2021

View reviewed changes

wren approved these changes Mar 6, 2021

View reviewed changes

micahellison added the bug Something isn't working label Mar 6, 2021

micahellison changed the title ~~Format pretty and format short bugs~~ Fix bug that prevented --format pretty and --format short from working Mar 6, 2021

micahellison merged commit a3f4f6b into jrnl-org:develop Mar 6, 2021

MinchinWeb added a commit to MinchinWeb/jrnl that referenced this pull request May 9, 2021

Convert "short" and "pretty" (and "default") formaters to plugins

1fd04ad

further to jrnl-org#1177

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bug that prevented --format pretty and --format short from working #1177

Fix bug that prevented --format pretty and --format short from working #1177

sriniv27 commented Feb 4, 2021 •

edited

Loading

wren left a comment

sriniv27 commented Feb 7, 2021

sriniv27 commented Feb 25, 2021

wren commented Feb 25, 2021

sriniv27 commented Feb 25, 2021

micahellison left a comment

wren left a comment

micahellison left a comment

micahellison left a comment

wren left a comment

Fix bug that prevented --format pretty and --format short from working #1177

Fix bug that prevented --format pretty and --format short from working #1177

Conversation

sriniv27 commented Feb 4, 2021 • edited Loading

Checklist

wren left a comment

Choose a reason for hiding this comment

sriniv27 commented Feb 7, 2021

sriniv27 commented Feb 25, 2021

wren commented Feb 25, 2021

sriniv27 commented Feb 25, 2021

micahellison left a comment

Choose a reason for hiding this comment

wren left a comment

Choose a reason for hiding this comment

micahellison left a comment

Choose a reason for hiding this comment

micahellison left a comment

Choose a reason for hiding this comment

wren left a comment

Choose a reason for hiding this comment

sriniv27 commented Feb 4, 2021 •

edited

Loading