Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the versions that weren't bumped when releasing 3.3.0 #2093

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

cristiano-belloni
Copy link
Contributor

@cristiano-belloni cristiano-belloni commented Sep 1, 2022

When merging #2027, the Github changesets bot didn't recognise all the changed packages automatically and we erroneously bumped only "modular-scripts" to minor (3.3.0).
The result is that we now are dependent from "@modular-scripts/workspace-resolver@1.0.0" (the old version) in modular-scripts@3.3.0 and modular fails when we try to use modular test --changed because it needs the newer version of workspace-resolver that was never published ([modular] (0 , _workspaceResolver.computeAncestorWorkspaces) is not a function).

This PR bumps the packages that weren't bumped before.

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2022

🦋 Changeset detected

Latest commit: e5ccdda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@modular-scripts/workspace-resolver Minor
modular-scripts Patch
@modular-scripts/modular-types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cristiano-belloni cristiano-belloni changed the title Bump the versions that weren't bumped before Bump the versions that weren't bumped when releasing 3.3.0 Sep 1, 2022
@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 33.885% when pulling e5ccdda on feature/publish-workspace-types into ed34d7e on main.

@cristiano-belloni cristiano-belloni merged commit 8e955c8 into main Sep 2, 2022
@cristiano-belloni cristiano-belloni deleted the feature/publish-workspace-types branch September 2, 2022 09:25
@github-actions github-actions bot mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants