Ghost testing #2027
Ghost testing #2027
Conversation
🦋 Changeset detectedLatest commit: 876b607 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| ); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| const { default: test } = await import('./test'); |
There was a problem hiding this comment.
Does importing ./test have side-effects?
There was a problem hiding this comment.
In that case it doesn't need a dynamic import - not something that's part of your PR, but might be easier to follow as a standard import at the top of the file.
There was a problem hiding this comment.
@steveukx in program.ts we parse the command line args and we decide which Modular command to execute. If we statically imported all of them at the start (which is translated to sync require in cjs world), it'd be a performance hit proportional to the quantity of commands.
| .option( | ||
| '--debug', | ||
| 'Setup node.js debugger on the test process - equivalent of setting --inspect-brk on a node.js process', | ||
| false, | ||
| ) | ||
| .option( | ||
| '--changed <branch>', |
There was a problem hiding this comment.
To allow for the future state of having --changed on its own to use the default / PR head, should this be a boolean with another option of --compare-branch
There was a problem hiding this comment.
Agree, it'd be clearer.
Ghost testing
This PR implements three new options for the
testcommand, which:Docs for
modular test:--ancestorsDefault:
falseCan be used only in combination with
changedor the command will fail. If set,it will additionally execute tests for all the workspaces that (directly or
indirectly) depend on the workspaces selected by
changed.--changedDefault:
falseExecute tests only for the workspaces that contain files that have changed.
Files that have changed are calculated comparing the current state of the
repository with the branch specified by
compareBranchor, ifcompareBranchis not set, with the default git branch.
--compareBranchDefault:
undefinedSpecify the comparison branch used to determine which files have changed when
using the
changedoption. If this option is used withoutchanged, thecommand will fail.
TODO:
--changed <branch>testing only changed workspaces--changedboolean separated from--compareBranch <branch>--ancestorstesting only changed workspaces and their ancestors--ancestorsonly with--changed--changedwithout regexesWorkspaceContents and returnWorkspaceContentwith ancestors