Skip to content

Commit

Permalink
fix(misc): fix commit history with missing items (carbon-design-syste…
Browse files Browse the repository at this point in the history
…m#575)

* fix(misc): misc fixes (carbon-design-system#530)

* chore(lint): remove console.log from overflow

* chore(build): remove node 4 from travis

* chore(ButtonSet): mark as deprecated (carbon-design-system#510)

Official carbon-components no longer need to use explicit containers for
pairing button components. Buttons will space themselves when primary
and secondary pairs are created.

* chore(CopyButton): deprecate the CopyButton

docs(CopyButton): mention availability of new CodeSnippet component

docs(CopyButton): remove ticks

* fix(InnerLeftNav): add missing aria-label

Fixes carbon-design-system#535

test(InteriorLeftNavList): update baseline a11y results
  • Loading branch information
iangfleming authored and marijohannessen committed Apr 24, 2017
1 parent cee316a commit b1c8151
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 27 deletions.
6 changes: 4 additions & 2 deletions .storybook/components/ButtonSetStory.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,13 @@ import { storiesOf } from '@kadira/storybook';
import ButtonSet from '../../components/ButtonSet';
import Button from '../../components/Button';

storiesOf('ButtonSet', module)
storiesOf('ButtonSet (Deprecated)', module)
.addWithInfo(
'',
`
Button Sets are container components used when an action required by the user has more than one option. Always use a
Button Sets are now deprecated.
When using SCSS from carbon-components, pairing Button components will automatically space themselves accordingly.
Pairing Button components are used when an action required by the user has more than one option. Always use a
positive action button (primary) paired with a negative action button (secondary). Positive action buttons
should be on the right, while negative action buttons will be on the left.
`,
Expand Down
4 changes: 3 additions & 1 deletion .storybook/components/CopyButtonStory.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@ import React from 'react';
import { action, storiesOf } from '@kadira/storybook';
import CopyButton from '../../components/CopyButton';

storiesOf('CopyButton', module)
storiesOf('CopyButton (Deprecated)', module)
.addWithInfo(
'',
`
The CopyButton has been deprecated in favor of a new CodeSnippet component that includes a new copy button.
The CodeSnippet component will be available in versions 3.0.0 and higher.
The copy button can be used when the user needs to copy information, such as a code snippet, to their clipboard.
`,
() => (
Expand Down
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
language: node_js
node_js:
- '4'
- '6'
group: bluezone
cache:
Expand Down
29 changes: 6 additions & 23 deletions a11y/baselines/InteriorLeftNavList.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
"rpt.g3.listMisuse": "List elements missing, or improperly structured. Do not use list elements for formatting.",
"wcag20.tech.aria.RequiredParent": "An element with WAI-ARIA role {0} is not contained in or owned by an element with one of the following WAI-ARIA roles: {1}. See rule help for remediation guidance.",
"wcag20.tech.aria.OrphanedContent": "All content must reside within a WAI-ARIA landmark or labelled region role.",
"wcag20.tech.aria.MissingKeyboardHandler": "The {0} element with WAI-ARIA role {1} might not be keyboard accessible. See rule help for remediation guidance.",
"rpt.g1110.widgetLabels": "A WAI-ARIA widget must have an accessible name (see message help text for details)."
"wcag20.tech.aria.MissingKeyboardHandler": "The {0} element with WAI-ARIA role {1} might not be keyboard accessible. See rule help for remediation guidance."
},
"lang": "en-us"
},
Expand Down Expand Up @@ -115,30 +114,14 @@
"width": 0
},
"level": "violation"
},
{
"severityCode": "eISHigh",
"messageCode": "rpt.g1110.widgetLabels",
"ruleId": "1110",
"help": "idhi_accessibility_check_g1110.html",
"msgArgs": [],
"xpath": "/html[1]/body[1]/li[1]/ul[1]",
"snippet": "<ul style=\"\" aria-hidden=\"true\" class=\"left-nav-list left-nav-list--nested\" role=\"menu\">",
"bounds": {
"left": 0,
"top": 0,
"height": 0,
"width": 0
},
"level": "violation"
}
],
"frameIdx": 0
}
],
"summary": {
"counts": {
"violation": 7
"violation": 6
},
"scanTime": 0,
"policies": [
Expand All @@ -148,9 +131,9 @@
"reportLevels": [
"violation"
],
"startScan": 1487698560555
"startScan": 1491921614285
},
"scanID": "922d93db-7fc7-47a1-9883-ece8bf58931e",
"toolID": "@ibma/aat-v1.1.0",
"scanID": "38ab4a0d-bc71-455a-aa52-d07075672196",
"toolID": "@ibma/aat-v1.2.0",
"label": "InteriorLeftNavList"
}
}
1 change: 1 addition & 0 deletions components/InteriorLeftNavList.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ class InteriorLeftNavList extends Component {
<ul
role="menu"
className="left-nav-list left-nav-list--nested"
aria-label={title}
aria-hidden
>
{newChildren}
Expand Down

0 comments on commit b1c8151

Please sign in to comment.