Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interesting “double outinline” on DataTable #510

Closed
eddiemonge opened this issue Jan 17, 2018 · 0 comments
Closed

Interesting “double outinline” on DataTable #510

eddiemonge opened this issue Jan 17, 2018 · 0 comments

Comments

@eddiemonge
Copy link
Contributor

eddiemonge commented Jan 17, 2018 •
edited
Loading

.bx--overflow-menu:focus has a box-shadow and the child svg has one as well .bx--data-table-v2 .bx--overflow-menu:focus .bx--overflow-menu__icon

image
tw15egan added a commit to tw15egan/carbon that referenced this issue Jan 19, 2018
@tw15egan
fix(data-table-v2): remove double focus outline on data-table, closes c…
092adb9 
…arbon-design-system#510
@tw15egan tw15egan mentioned this issue Jan 19, 2018
Merged
@tw15egan tw15egan self-assigned this Jan 19, 2018
tw15egan added a commit that referenced this issue Jan 19, 2018
@tw15egan
fix(data-table-v2): remove double focus outline on data-table, closes #…
f864f49 
…510 (#517)
joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@iangfleming @marijohannessen
fix(misc): fix commit history with missing items (carbon-design-syste…
b1c8151 
…m#575)

* fix(misc): misc fixes (carbon-design-system#530)

* chore(lint): remove console.log from overflow

* chore(build): remove node 4 from travis

* chore(ButtonSet): mark as deprecated (carbon-design-system#510)

Official carbon-components no longer need to use explicit containers for
pairing button components. Buttons will space themselves when primary
and secondary pairs are created.

* chore(CopyButton): deprecate the CopyButton

docs(CopyButton): mention availability of new CodeSnippet component

docs(CopyButton): remove ticks

* fix(InnerLeftNav): add missing aria-label

Fixes carbon-design-system#535

test(InteriorLeftNavList): update baseline a11y results
joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
fix(overflow): cast to array to discard false children (carbon-design…
bd08d0f 
…-system#579)

* fix(misc): misc fixes (carbon-design-system#530)

* chore(lint): remove console.log from overflow

* chore(build): remove node 4 from travis

* chore(ButtonSet): mark as deprecated (carbon-design-system#510)

Official carbon-components no longer need to use explicit containers for
pairing button components. Buttons will space themselves when primary
and secondary pairs are created.

* fix(overflowmenu): cast to array to discard null children first

* fix(overflow): those trailing commas
joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@asudoh @marijohannessen
feat(Toggle): support onChange event (carbon-design-system#521)
6d2ddd9 
Resolves carbon-design-system#510.
joshblack pushed a commit to joshblack/carbon that referenced this issue May 8, 2019
@shinytoyrobots @joshblack
chore(project): add stalebot (carbon-design-system#510)
bfc1220 
* Stalebot. Add exemptions after this runs once

* Update stale.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eddiemonge @marijohannessen @tw15egan