fix(NumberInput): handle case when input is invalid, resolves carbon-…

…design-system#436 (carbon-design-system#836) * fix(NumberInput): handle case when input is invalid, resolves carbon-design-system#436 * fix(NumberInput): handle case when input is invalid, resolves carbon-design-system#436
joshblack · May 4, 2018 · b00d244 · b00d244
1 parent a15e5b8
commit b00d244
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/components/NumberInput/NumberInput-test.js b/src/components/NumberInput/NumberInput-test.js
@@ -123,6 +123,13 @@ describe('NumberInput', () => {
           let numberInput = wrapper.find('input');
           expect(numberInput.prop('value')).toEqual(5);
         });
+
+        it('should set invalidText when value is empty string', () => {
+          wrapper.setProps({ value: '' });
+          const invalidText = wrapper.find('.bx--form-requirement');
+          expect(invalidText.length).toEqual(1);
+          expect(invalidText.text()).toEqual('invalid text');
+        });
       });
     });
 

diff --git a/src/components/NumberInput/NumberInput.js b/src/components/NumberInput/NumberInput.js
@@ -146,7 +146,7 @@ export default class NumberInput extends Component {
 
     const inputWrapperProps = {};
     let error = null;
-    if (invalid) {
+    if (invalid || this.state.value === '') {
       inputWrapperProps['data-invalid'] = true;
       error = <div className="bx--form-requirement">{invalidText}</div>;
     }