Code

Chore/state refactor#111

Code

Merged

josdejong merged 76 commits intomainjosdejong/svelte-jsoneditor:mainfrom chore/state_refactorjosdejong/svelte-jsoneditor:chore/state_refactorCopy head branch name to clipboardJul 5, 2022

+4,835-4,503

Commits

Commits on Jun 10, 2022

• chore: store expanded state in documentStateStore (WIP)

  josdejong

  committed
  7ff6d8f

  Copy full SHA for 7ff6d8f

• chore: add some unit tests and fix function accordingly

  josdejong

  committed
  e047c5e

  Copy full SHA for e047c5e

• chore: refactor validationErrors to the new model

  josdejong

  committed
  7bed677

  Copy full SHA for 7bed677

• chore: keep both validationErrors and validationErrorsMap in state

  josdejong

  committed
  0008a89

  Copy full SHA for 0008a89

Commits on Jun 13, 2022

• chore: move selection to documentState (WIP)

  josdejong

  committed
  a48844d

  Copy full SHA for a48844d

Commits on Jun 14, 2022

• chore: refactor search highlighting

  josdejong

  committed
  4584ca5

  Copy full SHA for 4584ca5

Commits on Jun 20, 2022

• chore: implement a new documentStatePatch (WIP)

  josdejong

  committed
  d2d643b

  Copy full SHA for d2d643b

• chore: refactor using PathStr as keys in the state to using JSONPointer

  josdejong

  committed
  1f8c7a6

  Copy full SHA for 1f8c7a6

Commits on Jun 21, 2022

• chore: fix dragging unit tests

  josdejong

  committed
  fe85375

  Copy full SHA for fe85375

• chore: more refactoring and removing of the old state

  josdejong

  committed
  e4b0bf0

  Copy full SHA for e4b0bf0

• chore: cleanup the now unused Symbols

  josdejong

  committed
  92d7345

  Copy full SHA for 92d7345

• chore: further refactoring of Selection

  josdejong

  committed
  c05f110

  Copy full SHA for c05f110

• chore: cleanup RecursiveSelection

  josdejong

  committed
  ef9c6c0

  Copy full SHA for ef9c6c0

• chore: make the editor render again (WIP)

  josdejong

  committed
  698f4cb

  Copy full SHA for 698f4cb

Commits on Jun 22, 2022

• chore: refactor the usages of derived stores a bit

  josdejong

  committed
  8267a2a

  Copy full SHA for 8267a2a

• chore: cleanup commented code

  josdejong

  committed
  b236cfe

  Copy full SHA for b236cfe

• chore: refactor documentState listeners

  josdejong

  committed
  ef3a662

  Copy full SHA for ef3a662

• fix: not being able to edit a key

  josdejong

  committed
  e193175

  Copy full SHA for e193175

Commits on Jun 23, 2022

• chore: minor refactoring

  josdejong

  committed
  4c3521e

  Copy full SHA for 4c3521e

• chore: cleanup some logging

  josdejong

  committed
  6bb94fb

  Copy full SHA for 6bb94fb

• chore: revert API change of AfterPatchCallback for now

  josdejong

  committed
  bac7b7a

  Copy full SHA for bac7b7a

• chore: pass pointer instead of path to JSONNode

  josdejong

  committed
  e7e6e2e

  Copy full SHA for e7e6e2e

• chore: rename PathsMap to JSONPointerMap

  josdejong

  committed
  91a5dd7

  Copy full SHA for 91a5dd7

• chore: refactor subscribing to documentStateStore with passing filtered maps (WIP)

  josdejong

  committed
  dc8cd3b

  Copy full SHA for dc8cd3b

Commits on Jun 24, 2022

• chore: move searchResult, validationErrors, and validationErrorsMap out of documentState

  josdejong

  committed
  c4fc8d4

  Copy full SHA for c4fc8d4

• chore: refactor AfterPatchCallback and updating of validationErrors

  josdejong

  committed
  977825e

  Copy full SHA for 977825e

• chore: change documentStateStore into a regular variable documentState

  josdejong

  committed
  5f6e859

  Copy full SHA for 5f6e859

• fix: scrollTo not working (path had indices as string instead of number

  josdejong

  committed
  888bfa6

  Copy full SHA for 888bfa6

• Merge branch 'main' into chore/state_refactor

  josdejong

  committed
  4b3578a

  Copy full SHA for 4b3578a

Commits on Jun 25, 2022

• chore: refactor onSelect and focus

  josdejong

  committed
  0b4edb2

  Copy full SHA for 0b4edb2

• fix: scrollTo using an old selection

  josdejong

  committed
  fc86c5c

  Copy full SHA for fc86c5c

• fix: insert area being rendered under wrong conditions

  josdejong

  committed
  d8221ca

  Copy full SHA for d8221ca

• fix: insert a new item or prop starting to edit the previous field

  josdejong

  committed
  a93751d

  Copy full SHA for a93751d

• fix: navigation keys up/down/left/right broken

  josdejong

  committed
  af74def

  Copy full SHA for af74def

Commits on Jun 27, 2022

• fix: apply move operations when reverting a patch operation to maintain the order of keys

  josdejong

  committed
  1f71bdf

  Copy full SHA for 1f71bdf

• chore: add debug logging

  josdejong

  committed
  290bf81

  Copy full SHA for 290bf81

• chore: remove keysMap and simplify function signatures where possible

  josdejong

  committed
  78dee5a

  Copy full SHA for 78dee5a

• fix: dragging up/down in an array not displaying the selected contents correctly

  josdejong

  committed
  404ae04

  Copy full SHA for 404ae04

• fix: get enforceString working again

  josdejong

  committed
  c4e7104

  Copy full SHA for c4e7104

• fix: a bug in enforceString when replacing search results

  josdejong

  committed
  cb9f8b1

  Copy full SHA for cb9f8b1

• chore: cleanup redundant as JSONPath TS conversions

  josdejong

  committed
  99c7bac

  Copy full SHA for 99c7bac

• fix: always apply changed enforceString contents and create a history item

  josdejong

  committed
  7735213

  Copy full SHA for 7735213

• chore: on undo/redo, don't change the expandedState, just expand&scroll to the restored selection

  josdejong

  committed
  6a0595c

  Copy full SHA for 6a0595c

• chore: cleanup some todo's

  josdejong

  committed
  b8e825f

  Copy full SHA for b8e825f

• fix: force to reset expandedState when invoking the public function expand

  josdejong

  committed
  ffc29e4

  Copy full SHA for ffc29e4

• chore: rename some occurrences of state to documentState for consistency

  josdejong

  committed
  018ba95

  Copy full SHA for 018ba95

• chore: cleanup some logging

  josdejong

  committed
  7e57a48

  Copy full SHA for 7e57a48

• chore: simplify deletePath

  josdejong

  committed
  a2d445d

  Copy full SHA for a2d445d

• chore: move type JSONPatch related type definitions to immutable-json-patch

  josdejong

  committed
  f2dd72f

  Copy full SHA for f2dd72f

Commits on Jun 28, 2022

• chore: cleanup some redundant type definitions

  josdejong

  committed
  d4cbc83

  Copy full SHA for d4cbc83

• fix: some wrong TypeScript imports

  josdejong

  committed
  af2a89e

  Copy full SHA for af2a89e

Commits on Jun 30, 2022

• fix: revert not working correctly (WIP, requires a not-yet-released of immutable-json-patch)

  josdejong

  committed
  b10b686

  Copy full SHA for b10b686

• chore: refactor JSONPath to only hold array indices as a string instead of a number (WIP)

  josdejong

  committed
  4635ed9

  Copy full SHA for 4635ed9

Commits on Jul 1, 2022

• chore: upgrade to immutable-json-patch@3.0.0

  josdejong

  committed
  6f79c4c

  Copy full SHA for 6f79c4c

• chore: rename Selection to JSONSelection to prevent confusion with the HTML Dom type Selection

  josdejong

  committed
  5e766c3

  Copy full SHA for 5e766c3

• chore: run CI tests on all branches

  josdejong

  committed
  cabab9e

  Copy full SHA for cabab9e

• fix: transform preview starting with fully selected text

  josdejong

  committed
  0cd75f5

  Copy full SHA for 0cd75f5

• chore: merge documentStateMove and documentStateCopy into documentStateMoveOrCopy

  josdejong

  committed
  1db8471

  Copy full SHA for 1db8471

• chore: put renamePointer on a single line

  josdejong

  committed
  58a439c

  Copy full SHA for 58a439c

• chore: minor refactoring

  josdejong

  committed
  70ef0c4

  Copy full SHA for 70ef0c4

• chore: fix having to call applySearch after updating content explicitly

  josdejong

  committed
  208080d

  Copy full SHA for 208080d

Commits on Jul 4, 2022

• chore: update all state whilst dragging

  josdejong

  committed
  a129d68

  Copy full SHA for a129d68

• chore: update pre-calculated list with props/items when dragging (WIP)

  josdejong

  committed
  b28a935

  Copy full SHA for b28a935

• chore: some cleanup and refactoring in the dragging logic

  josdejong

  committed
  de1d739

  Copy full SHA for de1d739

Commits on Jul 5, 2022

• fix: scrollTo not working from NavigationBar and SearchBox

  josdejong

  committed
  18336ea

  Copy full SHA for 18336ea

• fix: dragging not working in subsequent visible sections in a large array

  josdejong

  committed
  3a4e023

  Copy full SHA for 3a4e023

• fix: cannot drag starting at a selected, nested item

  josdejong

  committed
  74da903

  Copy full SHA for 74da903

• fix: first array item not being expanded by default

  josdejong

  committed
  5d04a8a

  Copy full SHA for 5d04a8a

• fix: object/array not being selected after sorting

  josdejong

  committed
  95fd38c

  Copy full SHA for 95fd38c

• fix: losing focus after closing the CopyPasteModal

  josdejong

  committed
  90a4be8

  Copy full SHA for 90a4be8

• fix: losing focus after opening JSONRepairModal, and action buttons throwing an exception

  josdejong

  committed
  cbcad8a

  Copy full SHA for cbcad8a

• fix: custom render value development demo

  josdejong

  committed
  e8421cc

  Copy full SHA for e8421cc

• fix: undo a value change selecting the key instead of the value

  josdejong

  committed
  f20325a

  Copy full SHA for f20325a

• fix: only scroll to selection on undo/redo when selection is outside the viewport

  josdejong

  committed
  9e12444

  Copy full SHA for 9e12444

• fix: undo/redo not restoring the previous expanded state

  josdejong

  committed
  dc336da

  Copy full SHA for dc336da

• fix: extend visible section when inserting a new item right at the end of a visible section

  josdejong

  committed
  33b71ac

  Copy full SHA for 33b71ac