Chore/state refactor #111
Merged
Chore/state refactor #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Map` out of `documentState`
…f `immutable-json-patch`)
…ad of a number (WIP)
…h the HTML Dom type `Selection`
…ntStateMoveOrCopy`
…hrowing an exception
…d of a visible section
josdejong
added a commit
that referenced
this pull request
Jul 5, 2022
BREAKING CHANGES: - The type `JSONPath` is changed from `Array<string | number>` to `Array<string>` - Some TypeScript types now come from `immutable-json-patch` All changes: - Refactor state from relying on a nested structure and Symbols into a solution that is lazy and uses a flat map with pointers. The new state is easier to understand and maintain. - Create and use helper functions like `createValueSelection` to create selections, and use type guards like `isValueSelection` everywhere to simplify the code. - Refactor `JSONPath` from having numeric indexes to having them as string (better compatible with `JSONPointer`, and less error-prone). - Use more TypeScript types from `immutable-json-patch` - Refactor and simplify the dragging logic - Fixes issues related to selection being updated after patch instead of in one go - Refactor more code to TypeScript - Add unit tests - Performance is comparable to what it was
josdejong
added a commit
that referenced
this pull request
Jul 6, 2022
BREAKING CHANGES: - The type `JSONPath` is changed from `Array<string | number>` to `Array<string>` - Some TypeScript types now come from `immutable-json-patch` All changes: - Refactor state from relying on a nested structure and Symbols into a solution that is lazy and uses a flat map with pointers. The new state is easier to understand and maintain. - Create and use helper functions like `createValueSelection` to create selections, and use type guards like `isValueSelection` everywhere to simplify the code. - Refactor `JSONPath` from having numeric indexes to having them as string (better compatible with `JSONPointer`, and less error-prone). - Use more TypeScript types from `immutable-json-patch` - Refactor and simplify the dragging logic - Fix issues related to selection being updated after patch instead of in one go - Refactor more code to TypeScript - Add unit tests - Performance is comparable to what it was
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createValueSelection(...)to create selections, and use type guards likeisValueSelectioneverywhere to simplify the code.