pull #1
Merged
pull #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yocto's bitbake sets global LDFLAGS that include the option --hash-style=gnu. If this option is ignored then bitbake's QA checks report that QA Issue: No GNU_HASH in the elf binary: '/[...]/opt/ros/indigo/lib/librealsense_camera_nodelet.so' [ldflags] The patch includes user defined linker flags to CMAKE_SHARED_LINKER_FLAGS defined in the project's CMakeList.txt. Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
realsense-camera: don't ignore linker flags set by user
Error message was assume only use was dynamic reconfigure Added boost as ROS dependency -- should have already been required.
Make system wrapper function generic
Added imu_start_ts for imu sync
Frame callbacks
Improve reliability of the camera by reducing the color stream to 30fps by default. This will be the highest frame rate which will be validate with VGA or higher resolutions for use with ROS. Default files will no longer use the librealsense preset modes as they will be depreciated in the future.
* Change color stream default to 30fps Improve reliability of the camera by reducing the color stream to 30fps by default. This will be the highest frame rate which will be validate with VGA or higher resolutions for use with ROS. Default files will no longer use the librealsense preset modes as they will be depreciated in the future.
Replaced boost::mutex with std::mutex
Fixes mutex lock and adds ZR300 destructor
The F200 and SR300 tests were attempting too much code reuse by include the r200_nodelet_default.launch file. When the Default launch files were changed to set 30fps as the new default for the color stream, F200/SR300 also had to set new defaults for the Depth stream to prevent using the invalid R200 depth default. The R200 default file does NOT pass the depth_width and depth_height to the nodelet so the override values were lost.
Due to a ROS bug which prevents publishing more than one static transform in separate processes, enable the use of dynamic camera transforms when needed for multiple camera support. Static transforms are still the default. See: ros/ros_comm#146 ros/geometry2#181
Many minor fixes to be compliant with ROS Lint standards.
Suppressing these for now, but should be investigated as they are not compliant with current ROS standards.
Modify the r200/sr300 RGBD-style launch files to no longer use the RGBD depth/ir/rgb_processing flags to control whether the corresponding stream is also enabled. For example, now turning off RGBD depth *processing* will no longer disable the depth stream itself.
Work around bug in librealsense where the callback for IR is called even if the stream is disabled if IR2 stream is enabled. See IntelRealSense/librealsense#393
Update RGBD launch files.
LR gain should be set only when LR auto exposure is disabled
Update Debug Tool
In OpenEmbedded setups where both meta-ros and meta-intel-realsense layers are used it's problematic to avoid two copies of librealsense installed onto an embedded target: one catkit-based installed under /opt/ros and one other installed to a standard system location. This patch adds an option making realsense_camera link against librealsense provided by the host system. By default the currently existing behavior is preserved. Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
roslint depends on catkin_run_tests_target() which is defined only when CATKIN_ENABLE_TESTING is True. Thus run roslint functions in CMakeLists.txt only when testing is enabled. Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
Add option to link against non-catkin librealsense
Revert to wait for frame for R200, F200, SR300 cameras
Fixed LR auto exposure issue
…ted copyright data on nodelets
Dynamic reconfigure of SR300 exposure controls
Fix build timing issue for catkin
Recent color auto exposure code changes are slightly different for SR300/F200/R200 from ZR300. Mainly the ZR300 needed the same if condition added for only setting the manual value when auto exposure is disabled.
Make ZR300 consistent with other cameras
The parameter is called tf_publication_rate
Enable configuration of the TF publication rate when using tf_dynamic
Otherwise librealsense won't be listed as a dependency for the nodelet that will fail to load due to undefined symbols. Signed-off-by: Murilo Belluzzo <murilo.belluzzo@intel.com>
librealsense: Fix link when the system library is used
Add RGDB launch file for the ZR300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure the above guidelines for contributing are met.
Fixes Issue: #
Changes proposed in this pull request: