Change color stream default to 30fps #164
Conversation
11d19fd to
e842cf0
Compare
| <!-- These 'arg' tags are just place-holders for passing values from test files. | ||
| The recommended way is to pass the values directly into the 'param' tags. --> | ||
| <arg name="enable_depth" default="true" /> | ||
| <arg name="enable_ir" default="true" /> |
There was a problem hiding this comment.
enable_ir and enable_ir2 defaults should be 'false'
| @@ -4,7 +4,34 @@ | |||
| <arg name="camera_type" default="F200" /> <!-- Type of camera --> | |||
| <arg name="serial_no" default="" /> | |||
| <arg name="usb_port_id" default="" /> <!-- USB "Bus#-Port#" --> | |||
| <arg name="manager" value="$(arg camera)_nodelet_manager" /> | |||
| <arg name="manager" value="nodelet_manager" /> | |||
There was a problem hiding this comment.
I realize you didn't change this, but should this be default= instead of value=? If it is default, it can be overridden by the command line if it is value, it is essentially hard-coded to "nodelet_manager". See this: http://wiki.ros.org/roslaunch/XML/arg. Same would apply for all the camera types.
There was a problem hiding this comment.
@reaganlo I thought we had made this a value instead of default to prevent the user from changing the name of the nodelet manager?
There was a problem hiding this comment.
Yes, we have defaults only for those fields that are likely to be changed by users.
There was a problem hiding this comment.
@mdhorn On second thoughts I think lets keep it consistent and have everything as "defaults". I feel there is no harm in doing so.
There was a problem hiding this comment.
@reaganlo I'm reformatting the contents of the default files. I've tested, and I can switch to manual mode and ONLY set manual mode and the color FPS -- much simpler default file.
I'll be resubmitting this PR shortly.
Improve reliability of the camera by reducing the color stream to 30fps by default. This will be the highest frame rate which will be validate with VGA or higher resolutions for use with ROS. Default files will no longer use the librealsense preset modes as they will be depreciated in the future.
6928e2b to
fdc341a
Compare
Improve reliability of the camera by reducing the color stream
to 30fps by default. This will be the highest frame rate which will
be validate with VGA or higher resolutions for use with ROS.
Default files will no longer use the librealsense preset modes
as they will be depreciated in the future.