Fix Xcode 10.2 warnings #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'public' modifier is redundant for instance method declared in a public extension
mdiep
commented
Apr 1, 2019
| ORGANIZATIONNAME = "Glazed Donut, LLC."; | ||
| TargetAttributes = { | ||
| 8A569F3F1E6B3E50008BE2AC = { | ||
| CreatedOnToolsVersion = 8.2.1; | ||
| LastSwiftMigration = 0900; | ||
| LastSwiftMigration = 1020; |
There was a problem hiding this comment.
I didn't do the Swift migration, obviously. I just cleared the Remind Me box so that it wouldn't show up as a warning.
| hasScannedForEncodings = 0; | ||
| knownRegions = ( | ||
| en, | ||
| Base, |
There was a problem hiding this comment.
Xcode 10.2 is pretty insistent on these localization changes.
| @@ -23,7 +23,7 @@ public protocol DownASTRenderable: DownRenderable { | |||
| func toAST(_ options: DownOptions) throws -> UnsafeMutablePointer<cmark_node> | |||
| } | |||
|
|
|||
| public extension DownASTRenderable { | |||
| extension DownASTRenderable { | |||
There was a problem hiding this comment.
Since the methods in this extension are public, marking this as public too is a warning in the Swift 5 compiler.
iwasrobbed
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.