Fix Xcode 10.2 warnings (#130)

* Remove redundant 'public' modifiers 'public' modifier is redundant for instance method declared in a public extension * Xcode 10.2 recommended settings * Clear the Swift migration check
johnxnguyen · Apr 2, 2019 · 1fecb4b · 1fecb4b
1 parent 8b1f549
commit 1fecb4b
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 12 deletions.
diff --git a/Down.xcodeproj/project.pbxproj b/Down.xcodeproj/project.pbxproj
@@ -448,27 +448,28 @@
 			isa = PBXProject;
 			attributes = {
 				LastSwiftUpdateCheck = 0820;
-				LastUpgradeCheck = 1010;
+				LastUpgradeCheck = 1020;
 				ORGANIZATIONNAME = "Glazed Donut, LLC.";
 				TargetAttributes = {
 					8A569F3F1E6B3E50008BE2AC = {
 						CreatedOnToolsVersion = 8.2.1;
-						LastSwiftMigration = 0900;
+						LastSwiftMigration = 1020;
 						ProvisioningStyle = Automatic;
 					};
 					8AFAEAFA1E6E32E900E09B68 = {
 						CreatedOnToolsVersion = 8.2.1;
-						LastSwiftMigration = 0900;
+						LastSwiftMigration = 1020;
 						ProvisioningStyle = Automatic;
 					};
 				};
 			};
 			buildConfigurationList = D4201E7A1CFA5151008EEC6E /* Build configuration list for PBXProject "Down" */;
 			compatibilityVersion = "Xcode 3.2";
-			developmentRegion = English;
+			developmentRegion = en;
 			hasScannedForEncodings = 0;
 			knownRegions = (
 				en,
+				Base,
 			);
 			mainGroup = D4201E761CFA5151008EEC6E;
 			productRefGroup = D4201E811CFA5151008EEC6E /* Products */;
@@ -657,6 +658,7 @@
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
 				CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES;
+				CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
 				CLANG_ANALYZER_NONNULL = YES;
 				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
 				CLANG_CXX_LIBRARY = "libc++";
@@ -721,6 +723,7 @@
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
 				CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES;
+				CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
 				CLANG_ANALYZER_NONNULL = YES;
 				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
 				CLANG_CXX_LIBRARY = "libc++";

diff --git a/Down.xcodeproj/xcshareddata/xcschemes/Down.xcscheme b/Down.xcodeproj/xcshareddata/xcschemes/Down.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1010"
+   LastUpgradeVersion = "1020"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/Source/Renderers/DownASTRenderable.swift b/Source/Renderers/DownASTRenderable.swift
@@ -23,7 +23,7 @@ public protocol DownASTRenderable: DownRenderable {
     func toAST(_ options: DownOptions) throws -> UnsafeMutablePointer<cmark_node>
 }
 
-public extension DownASTRenderable {
+extension DownASTRenderable {
     /**
      Generates an abstract syntax tree from the `markdownString` property
 

diff --git a/Source/Renderers/DownAttributedStringRenderable.swift b/Source/Renderers/DownAttributedStringRenderable.swift
@@ -25,7 +25,7 @@ public protocol DownAttributedStringRenderable: DownHTMLRenderable {
     func toAttributedString(_ options: DownOptions, stylesheet: String?) throws -> NSAttributedString
 }
 
-public extension DownAttributedStringRenderable {
+extension DownAttributedStringRenderable {
     /**
      Generates an `NSAttributedString` from the `markdownString` property
 

diff --git a/Source/Renderers/DownCommonMarkRenderable.swift b/Source/Renderers/DownCommonMarkRenderable.swift
@@ -24,7 +24,7 @@ public protocol DownCommonMarkRenderable: DownRenderable {
     func toCommonMark(_ options: DownOptions, width: Int32) throws -> String
 }
 
-public extension DownCommonMarkRenderable {
+extension DownCommonMarkRenderable {
     /**
      Generates a CommonMark Markdown string from the `markdownString` property
 

diff --git a/Source/Renderers/DownGroffRenderable.swift b/Source/Renderers/DownGroffRenderable.swift
@@ -24,7 +24,7 @@ public protocol DownGroffRenderable: DownRenderable {
     func toGroff(_ options: DownOptions, width: Int32) throws -> String
 }
 
-public extension DownGroffRenderable {
+extension DownGroffRenderable {
     /**
      Generates a groff man string from the `markdownString` property
 

diff --git a/Source/Renderers/DownHTMLRenderable.swift b/Source/Renderers/DownHTMLRenderable.swift
@@ -23,7 +23,7 @@ public protocol DownHTMLRenderable: DownRenderable {
     func toHTML(_ options: DownOptions) throws -> String
 }
 
-public extension DownHTMLRenderable {
+extension DownHTMLRenderable {
     /**
      Generates an HTML string from the `markdownString` property
 

diff --git a/Source/Renderers/DownLaTeXRenderable.swift b/Source/Renderers/DownLaTeXRenderable.swift
@@ -24,7 +24,7 @@ public protocol DownLaTeXRenderable: DownRenderable {
     func toLaTeX(_ options: DownOptions, width: Int32) throws -> String
 }
 
-public extension DownLaTeXRenderable {
+extension DownLaTeXRenderable {
     /**
      Generates a LaTeX string from the `markdownString` property
 

diff --git a/Source/Renderers/DownXMLRenderable.swift b/Source/Renderers/DownXMLRenderable.swift
@@ -23,7 +23,7 @@ public protocol DownXMLRenderable: DownRenderable {
     func toXML(_ options: DownOptions) throws -> String
 }
 
-public extension DownXMLRenderable {
+extension DownXMLRenderable {
     /**
      Generates an XML string from the `markdownString` property