Add default revisions for jj sign
#5825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00e9c42 to
d836074
Compare
|
Same question as #5823 (comment): if this PR makes it into the same release as #4747, I think we don't need an extra changelog entry, do we? // edit |
When signing commits with `jj sign`, one might want to use a workflow like: ```bash jj fix && jj sign .. && jj git push ``` Making the default value for `-r`/`--revisions` configurable, will allow such a workflow. Co-Authored-By: Yuya Nishihara <yuya@tcha.org>
d836074 to
1f701eb
Compare
No, so the current approach should be fine. |
yuja
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5428
Checklist
If applicable:
CHANGELOG.md