sign: add default revisions for jj sign

When signing commits with `jj sign`, one might want to use a workflow
like:

```bash
jj fix && jj sign .. && jj git push
```

Making the default value for `-r`/`--revisions` configurable, will allow
such a workflow.

Co-Authored-By: Yuya Nishihara <yuya@tcha.org>

Author: pylbrecht

cli/src/commands/sign.rs

@@ -32,6 +32,8 @@ use crate::ui::Ui;
 pub struct SignArgs {
     /// What revision(s) to sign
     ///
+    /// If no revisions are specified, this defaults to the `revsets.sign` setting.
+    ///
     /// Note that revisions are always re-signed.
     ///
     /// While that leads to discomfort for users, which sign with hardware
@@ -55,10 +57,14 @@ pub fn cmd_sign(ui: &mut Ui, command: &CommandHelper, args: &SignArgs) -> Result
         ));
     }
 
-    let to_sign: IndexSet<Commit> = workspace_command
-        .parse_union_revsets(ui, &args.revisions)?
-        .evaluate_to_commits()?
-        .try_collect()?;
+    let revset_expression = if args.revisions.is_empty() {
+        let revset_string = workspace_command.settings().get_string("revsets.sign")?;
+        workspace_command.parse_revset(ui, &RevisionArg::from(revset_string))?
+    } else {
+        workspace_command.parse_union_revsets(ui, &args.revisions)?
+    };
+
+    let to_sign: IndexSet<Commit> = revset_expression.evaluate_to_commits()?.try_collect()?;
 
     workspace_command.check_rewritable(to_sign.iter().ids())?;
 

cli/src/config-schema.json

@@ -512,6 +512,11 @@
                     "type": "string",
                     "description": "Default set of revisions to simplify when no explicit revset is given for jj simplify-parents",
                     "default": "reachable(@, mutable())"
+                },
+                "sign": {
+                    "type": "string",
+                    "description": "Default set of revisions to sign when no explicit revset is given for jj sign",
+                    "default": "reachable(@, mutable())"
                 }
             },
             "additionalProperties": {

cli/src/config/revsets.toml

@@ -8,6 +8,7 @@ simplify-parents = "reachable(@, mutable())"
 # evaluate, lengthy warning messages would be printed. Use present(expr) to
 # suppress symbol resolution error.
 log = "present(@) | ancestors(immutable_heads().., 2) | present(trunk())"
+sign = "reachable(@, mutable())"
 
 [revset-aliases]
 # trunk() can be overridden as '<bookmark>@<remote>'. Use present(trunk()) if

cli/tests/cli-reference@.md.snap

@@ -2227,6 +2227,8 @@ Cryptographically sign a revision
 
 * `-r`, `--revisions <REVSETS>` — What revision(s) to sign
 
+   If no revisions are specified, this defaults to the `revsets.sign` setting.
+
    Note that revisions are always re-signed.
 
    While that leads to discomfort for users, which sign with hardware devices, as of now we cannot reliably check if a commit is already signed by the user without creating a signature (see https://github.com/jj-vcs/jj/issues/5786).

cli/tests/test_sign_unsign_commands.rs

@@ -98,6 +98,42 @@ backend = "test"
     ");
 }
 
+#[test]
+fn test_sign_default_revset() {
+    let test_env = TestEnvironment::default();
+
+    test_env.add_config(
+        r#"
+[ui]
+show-cryptographic-signatures = true
+
+[signing]
+behavior = "keep"
+backend = "test"
+"#,
+    );
+
+    test_env.run_jj_in(".", ["git", "init", "repo"]).success();
+    let repo_path = test_env.env_root().join("repo");
+    test_env
+        .run_jj_in(&repo_path, ["commit", "-m", "one"])
+        .success();
+
+    test_env.add_config("revsets.sign = '@'");
+
+    test_env.run_jj_in(&repo_path, ["sign"]).success();
+
+    let output = test_env.run_jj_in(&repo_path, ["log", "-r", "all()"]);
+    insta::assert_snapshot!(output, @r"
+    @  rlvkpnrz test.user@example.com 2001-02-03 08:05:09 8623fdf2 [✓︎]
+    │  (empty) (no description set)
+    ○  qpvuntsm test.user@example.com 2001-02-03 08:05:08 876f4b7e
+    │  (empty) one
+    ◆  zzzzzzzz root() 00000000
+    [EOF]
+    ");
+}
+
 #[test]
 fn test_warn_about_signing_commits_not_authored_by_me() {
     let test_env = TestEnvironment::default();