Disable format button without Prettier applied #3545
Conversation
| @@ -370,7 +370,8 @@ describe('Landscape', () => { | |||
| const [appliedModules] = modules.applyAll.lastCall.args as ModulesToApply[]; | |||
| expect(appliedModules.modules.map(slug => slug.get())).toEqual(['vue']); | |||
| expect(wrapper.find(wrappedElement('modules-apply-new-button')).attributes('disabled')).toBeDefined(); | |||
|
|
|||
| const component: any = wrapper.vm; | |||
| expect(component.isApplied('vue')).toBeTruthy(); | |||
There was a problem hiding this comment.
maybe another assert with a not applied one?
|
The tests are failing because the "Format" Button are disabled by default, as "Prettier" is not applied, I see two ways:
Which one is better ? |
f77ba2e to
d4fa0a4
Compare
|
@wmarques I tried to fix it with a PR on this PR: wmarques#1 is it what you intended? |
|
Yes indeed ! Thanks ! I'll fix merge conflict tomorrow and hope it will be good |
926e9c6 to
c13f2a4
Compare
c13f2a4 to
641f1a0
Compare
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #3545 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 2010 2010
===========================================
Files 529 529
Lines 8714 8719 +5
Branches 171 172 +1
===========================================
+ Hits 8714 8719 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Fix #3278