-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing the format / indent does not seem to work #4199
Comments
I guess you are clicking the format button somewhere in the process? We need to update this button activation to be bound to prettier application |
Yes I clicked "Apply selected" only then the "Format" button became active and I clicked it. Also I noticed changing the line ending has no effect - I always get "lf". |
Did you select prettier module? |
I didn't but I checked now and nothing changed. |
Just made some test, forgot the activation updates were already done (here #3545)... Ok, so looks like we need to add npm in the docker image :D. cc @pascalgrimaud |
I used the Docker container. And I see that the TraceProjectFormatter is not trying too hard to even check for NPM :) |
Yep, this the instance used when no npm installation can be found :D. We need to add npm in the published docker image :) |
Indeed, it would be a good enhancement |
@pascalgrimaud where is the root image used to publish on docker hub? |
Ok, adding npm should be pretty straightforward so, do you consider it a good first issue? |
I don't think it's a good first issue :-D |
Ok, my bad, I though this just needs something like this:
|
Maybe your solution can work, but it needs to be tested |
Of course, just dropped some stuff here |
I am using the UI provided by the Docker container. I only get indent size of two spaces.
The log shows:
The text was updated successfully, but these errors were encountered: