Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2: add account context #1005

Merged
merged 17 commits into from
Mar 17, 2022
Merged

OAuth2: add account context #1005

merged 17 commits into from
Mar 17, 2022

Conversation

pascalgrimaud
Copy link
Member

@pascalgrimaud pascalgrimaud commented Mar 11, 2022 •
edited
Loading

@pascalgrimaud pascalgrimaud marked this pull request as draft March 11, 2022 17:07
@codecov
Copy link

codecov bot commented Mar 11, 2022 •
edited
Loading

Codecov Report

Merging #1005 (290c462) into main (0ea61c5) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #1005   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1410      1421   +11     
===========================================
  Files            266       266           
  Lines           4426      4496   +70     
  Branches          86        86           
===========================================
+ Hits            4426      4496   +70
Impacted Files Coverage Δ
...ructure/primary/exception/ExceptionTranslator.java 100.00% <ø> (ø)
...pster/lite/generator/project/domain/Constants.java 100.00% <100.00%> (ø)
.../application/OAuth2SecurityApplicationService.java 100.00% <100.00%> (ø)
...oot/mvc/security/oauth2/domain/OAuth2Security.java 100.00% <100.00%> (ø)
...ity/oauth2/domain/OAuth2SecurityDomainService.java 100.00% <100.00%> (ø)
...structure/primary/rest/OAuth2SecurityResource.java 100.00% <100.00%> (ø)
...oot/mvc/web/domain/SpringBootMvcDomainService.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea61c5...290c462. Read the comment docs.

@pascalgrimaud pascalgrimaud force-pushed the oauth2-account-context branch from cf6479d to 19b9fbc Compare March 12, 2022 08:22
@pascalgrimaud
Copy link
Member Author

Still working on this last item, code from generator-jhipster :-(

image

@pascalgrimaud pascalgrimaud marked this pull request as ready for review March 12, 2022 10:59
@pascalgrimaud pascalgrimaud marked this pull request as draft March 12, 2022 16:45
@pascalgrimaud pascalgrimaud force-pushed the oauth2-account-context branch 2 times, most recently from 5d90eee to 09ef1a8 Compare March 16, 2022 22:51
@pascalgrimaud pascalgrimaud force-pushed the oauth2-account-context branch from 09ef1a8 to 3b04cbe Compare March 17, 2022 17:47
@pascalgrimaud pascalgrimaud marked this pull request as ready for review March 17, 2022 19:48
@pascalgrimaud
Copy link
Member Author

Your last comment was very important, so thanks a lot for the review @Bolo89
I'm merging this

@pascalgrimaud pascalgrimaud merged commit 2d05692 into jhipster:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bolo89 Bolo89 Bolo89 left review comments

Assignees
No one assigned
Labels
area: feature request 💡 server: spring boot theme: security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OAuth2: account context
2 participants
@pascalgrimaud @Bolo89