OAuth2: fix sonar code smells

jhipster · Mar 17, 2022 · 290c462 · 290c462
1 parent 27cbb35
commit 290c462
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.../jhipster/lite/generator/server/springboot/mvc/security/oauth2/domain/OAuth2Security.java b/.../jhipster/lite/generator/server/springboot/mvc/security/oauth2/domain/OAuth2Security.java
@@ -14,6 +14,7 @@ public class OAuth2Security {
   public static final String SECURITY_OAUTH2_DOMAIN = getPath(SECURITY_OAUTH2, DOMAIN);
   public static final String SECURITY_OAUTH2_INFRASTRUCTURE = getPath(SECURITY_OAUTH2, INFRASTRUCTURE);
   public static final String SECURITY_OAUTH2_INFRASTRUCTURE_CONFIG = getPath(SECURITY_OAUTH2, CONFIG);
+  public static final String TECHNICAL_INFRASTRUCTURE_PRIMARY_EXCEPTION = getPath(TECHNICAL_PRIMARY, "exception");
 
   public static final String ERROR_DOMAIN = "error/domain";
 

diff --git a/...e/generator/server/springboot/mvc/security/oauth2/domain/OAuth2SecurityDomainService.java b/...e/generator/server/springboot/mvc/security/oauth2/domain/OAuth2SecurityDomainService.java
@@ -137,7 +137,7 @@ private void updateIntegrationTestWithMockUser(Project project) {
   private void updateExceptionTranslatorWithAccountExceptionHandler(Project project) {
     String packageName = project.getPackageName().orElse(DEFAULT_PACKAGE_NAME);
     String packageNamePath = project.getPackageNamePath().orElse(getPath(PACKAGE_PATH));
-    String exceptionTranslatorPath = getPath(MAIN_JAVA, packageNamePath, "technical/infrastructure/primary/exception");
+    String exceptionTranslatorPath = getPath(MAIN_JAVA, packageNamePath, TECHNICAL_INFRASTRUCTURE_PRIMARY_EXCEPTION);
     String exceptionTranslatorFile = "ExceptionTranslator.java";
 
     String oldImport = "import org.zalando.problem.violations.ConstraintViolationProblem;";
@@ -165,7 +165,7 @@ public ResponseEntity<Problem> handleAccountException(AccountException ex, Nativ
   private void updateExceptionTranslatorTestController(Project project) {
     String packageName = project.getPackageName().orElse(DEFAULT_PACKAGE_NAME);
     String packageNamePath = project.getPackageNamePath().orElse(getPath(PACKAGE_PATH));
-    String exceptionTranslatorPath = getPath(TEST_JAVA, packageNamePath, "technical/infrastructure/primary/exception");
+    String exceptionTranslatorPath = getPath(TEST_JAVA, packageNamePath, TECHNICAL_INFRASTRUCTURE_PRIMARY_EXCEPTION);
     String fileToReplace = "ExceptionTranslatorTestController.java";
 
     String oldImport = "import org.springframework.http.converter.HttpMessageConversionException;";
@@ -190,9 +190,8 @@ public void accountException() {
   }
 
   private void updateExceptionTranslatorIT(Project project) {
-    String packageName = project.getPackageName().orElse(DEFAULT_PACKAGE_NAME);
     String packageNamePath = project.getPackageNamePath().orElse(getPath(PACKAGE_PATH));
-    String exceptionTranslatorPath = getPath(TEST_JAVA, packageNamePath, "technical/infrastructure/primary/exception");
+    String exceptionTranslatorPath = getPath(TEST_JAVA, packageNamePath, TECHNICAL_INFRASTRUCTURE_PRIMARY_EXCEPTION);
     String fileToReplace = "ExceptionTranslatorIT.java";
 
     String oldNeedle = "// jhipster-needle-exception-translator-it";