Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced overwrite flag for build publish command which overwrites builds with same number #2873

Merged
merged 18 commits into from
Feb 19, 2025

Conversation

bhanurp
Copy link
Collaborator

@bhanurp bhanurp commented Feb 13, 2025

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

  • An optional --overwrite flag is added to build publish command to overwrite build info with same build number.
  • Artifacts wont be affected

Depends on

@bhanurp bhanurp force-pushed the build-info-overwrite branch from cc3a051 to 82bf440 Compare February 13, 2025 11:14
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 13, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 13, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 13, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 13, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 13, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 13, 2025
@RobiNino
Copy link
Contributor

Perhaps we should also add a simple dry run test, or enhance the existing TestBuildPublishDryRun

Co-authored-by: Robi Nino <robin@jfrog.com>
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 19, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 19, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 19, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 19, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 19, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 19, 2025
@bhanurp
Copy link
Collaborator Author

bhanurp commented Feb 19, 2025

Perhaps we should also add a simple dry run test, or enhance the existing TestBuildPublishDryRun

Updated TestBuildPublishDryRun with test for overwrite

@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 19, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 19, 2025
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@bhanurp bhanurp merged commit 97b96b6 into jfrog:dev Feb 19, 2025
63 checks passed
@bhanurp bhanurp added new feature Automatically generated release notes and removed feature request New feature or request labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants