fix: make reporters respect useStderr option

[SimenB]

Summary

useStderr is currently respected for console output, but not our reporter. That's perhaps on purpose, but it was en easy enough fix to make, so I thought why not 🙂

If this is not accepted, the issue should be closed.

Fixes #5064

Test plan

Ran script in #5064 and it now printed stdout instead.

[SimenB]

Ugh, this broke horribly :(

[aaronabramov]

i also remember that we were not buffering stderr in reporters, because if something goes terribly wrong, writes to stderr and blows up we wouldn't get any error printed

[connorjclark]

Would benefit from this fix. @SimenB , any insight on what broke? Would be happy to jump in if you don't have the time.

[SimenB]

I don't think any functionality broke. A lot is how the integration tests are written - they fetch errors from stderr and have expectations on what's there and what's not. Feel free to jump in and take a look :)

[connorjclark]

Ah, understood. Will try tonight.

[thymikee]

@SimenB you think it makes sense to pursue fixing all the tests?

[MitchLillie]

Is this still in progress? Would love to see a resolution to this issue, happy to delve into helping with tests as well

[SimenB]

Help would be greatly appreciated!

An aside is, should we print the summary to stderr if we exit with code 1 regardless if useStderr is set or not?

[ByronBecker]

@SimenB @thymikee Is this feature still in progress? It seems someone has made a package to address this issue -> https://github.com/chrisgalvan/jest-standard-reporter

[lucasfcosta]

Hi @SimenB I'm happy to help with this if needed 😊

I was taking a look at what's currently in master and it seems like your PR is pretty much what's currently needed, we just gotta rebase it.

I was also searching for any other issues or PRs blocking this one but couldn't find any. Is this what's currently blocking the PR?

An aside is, should we print the summary to stderr if we exit with code 1 regardless if useStderr is set or not?

My 2 cents: I think that the summary should be printed to stdout since it's not an error message itself. Since the summary is a piece of information which would be printed regardless of whether there's an error, I think it should go into stdout.

---

Just let me know what can I do to help you and I'll do my best to answer timely. I'm happy to rebase/solve conflicts and open a PR or push to your branch (given write access to it) if you prefer.

[SimenB]

Thanks @lucasfcosta! I just rebased this - feel free to open up a new PR based on it which closes this one if you make it work 🙂

[marcoebbinghaus]

any news on this topic?

[kenrick95]

Hi, wanna let you know that in the past few days, I attempted to fix all these errors and now have a PR in which all tests are passing (#10054), but I apologize for touching so many files (113 files changed) 😨

I hope the maintainer can slowly take their time to review the changes and I will help to keep rebasing/resolving conflicts on the branch if needed

[PabloSzx]

any news?

[TheBit]

Any news?

[github-actions]

This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

[github-actions]

This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.