Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make reporters respect useStderr option #10054

Closed
wants to merge 64 commits into from

Conversation

kenrick95
Copy link
Contributor

@kenrick95 kenrick95 commented May 16, 2020

Summary

This is an attempt to fix #5064 which is built on top of #6583

I do apologize for the huge PR which contains lots of commits and lots of files changed. I will help to rebase/solve conflicts if such need arise.

  • Logic changes at default_reporter.ts and summary_reporter.ts to use for .. of instead of forEach because in forEach the scope of this gets rewired to undefined when calling BaseReporter.log
  • Most of them are just replacing stderr to stdout
  • stderr is still used when the run is triggered with --json
  • At some tests, I added --useStderr to preserve the old tests. Some places do rely on solely printing to stdout and therefore the results need to be piped away (or to be regexed heavily). At such places where --useStderr is used, I added a comment

As per 2020-05-17, I think I've fixed most of the test failures 🤞 I can only guess some of my fixes as I'm running on a Windows machine and couldn't reproduce those errors to fix (those tests are skipped on Windows)

Update 2020-05-18, all tests are passing now 🎉 but not sure how the maintainers can review 😅

Test plan

I believe in CIs

@kenrick95 kenrick95 changed the title WIP: [Attempt] fix: make reporters respect useStderr option fix: make reporters respect useStderr option May 17, 2020
@kenrick95 kenrick95 marked this pull request as ready for review May 17, 2020 15:23
@kenrick95
Copy link
Contributor Author

Closing this since the change was too big to review, and takes too much effort to maintain the branch

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest is using stderr as output
3 participants