Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add obscure Excel-formats to mapping.less #676

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −2
Open

Add obscure Excel-formats to mapping.less #676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc0155d
Add obscure Excel-formats to mapping.less
HoldYourWaffle Feb 4, 2023
7796400
Remove duplicate xls
HoldYourWaffle Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions styles/components/icons/mapping.less
View file
Original file line number Diff line number Diff line change
@@ -94,8 +94,6 @@

// CSV
.icon-set(".csv", "csv", @green);
.icon-set(".xls", "xls", @green);
.icon-set(".xlsx", "xls", @green);

// CUDA
.icon-set(".cu", "cu", @green);
@@ -124,6 +122,19 @@
// ELM
.icon-set(".elm", "elm", @blue);

// EXCEL
.icon-set(".xlsx", "xls", @green);
.icon-set(".xlsm", "xls", @green);
.icon-set(".xlsb", "xls", @green);
.icon-set(".xltx", "xls", @green);
.icon-set(".xltm", "xls", @green);
.icon-set(".xls", "xls", @green);
.icon-set(".xlt", "xls", @green);
.icon-set(".xlam", "xls", @green);
.icon-set(".xla", "xls", @green);
.icon-set(".xlw", "xls", @green);
.icon-set(".xlr", "xls", @green);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .xlw and .xlr format are depreciated and rarely used, so they should probably be ommitted.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these formats are rarely used, why would that be a reason to not give them an icon?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason to remove them imo is still that they are depreciated. You can't even save to those 2 formats with the modern version of Excel unlike for all the others.

image

The fact that these 2 are extremely rare is just the cherry on top.


// FAVICON
.icon-set(".ico", "favicon", @yellow);