Add obscure Excel-formats to mapping.less #676
Conversation
|
K |
| .icon-set(".xlam", "xls", @green); | ||
| .icon-set(".xla", "xls", @green); | ||
| .icon-set(".xlw", "xls", @green); | ||
| .icon-set(".xlr", "xls", @green); |
There was a problem hiding this comment.
The .xlw and .xlr format are depreciated and rarely used, so they should probably be ommitted.
There was a problem hiding this comment.
Most of these formats are rarely used, why would that be a reason to not give them an icon?
There was a problem hiding this comment.
The main reason to remove them imo is still that they are depreciated. You can't even save to those 2 formats with the modern version of Excel unlike for all the others.
The fact that these 2 are extremely rare is just the cherry on top.
|
For the record, I would not say that xlsm, xlsb, xla and xlam are "obscure" as long as one is familiar with VBA. And considering that the VBA extensions for VS Code have a non-negligible amount of downloads, I'm sure there is enough VBA devs using VS Code to justify having those icons added.
|
Noticed this omission while working with xltx-files, figured I might as well fix it.
I used this list of Excel's supported file extensions.