Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update <select> config appearance #202

Closed
wants to merge 1 commit into from
Closed

Update <select> config appearance #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions ...sources/org/jenkinsci/plugins/workflow/flow/GlobalDefaultFlowDurabilityLevel/global.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,17 @@
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
<f:section title="Pipeline Speed/Durability Settings">
<f:entry title="${%Pipeline Default Speed/Durability Level}" field="durabilityHint">
<select class="setting-input" name="durabilityHint">
<f:option value="null" selected="${instance[field] == null}">None: use pipeline default (<j:out value="${descriptor.suggestedDurabilityHint.name()}" />)</f:option>
<j:forEach var="it" items="${descriptor.durabilityHintValues}">
<j:set var="optionBody" encode="false">${it.description}</j:set>
<option value="${it.name()}"
selected="${(it==instance[field]) ? 'true':null}"
tooltip="${it.tooltip}"><j:out value="${optionBody}"/></option>
</j:forEach>
</select>
<div class="jenkins-select">
<select class="jenkins-select__input" name="durabilityHint">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change appears to be backwards and forwards compatible

Suggested change
<select class="jenkins-select__input" name="durabilityHint">
<!-- TODO Remove setting-input when baseline above 2.335 -->
<select class="jenkins-select__input setting-input" name="durabilityHint">

<f:option value="null" selected="${instance[field] == null}">None: use pipeline default (<j:out value="${descriptor.suggestedDurabilityHint.name()}" />)</f:option>
<j:forEach var="it" items="${descriptor.durabilityHintValues}">
<j:set var="optionBody" encode="false">${it.description}</j:set>
<option value="${it.name()}"
selected="${(it==instance[field]) ? 'true':null}"
tooltip="${it.tooltip}"><j:out value="${optionBody}"/></option>
</j:forEach>
</select>
</div>
</f:entry>
</f:section>
<br/><br/>
</j:jelly>