Update <select> config appearance

[janfaracik]

This PR updates the <select> config appearance to use the new classes introduced in Jenkins #5923.

Before

After

Just a heads up that the pre-existing tooltip attribute seemingly doesn't do anything on <option>, tried it on Safari and Chrome.

Cheers.

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[olamy]

this will need to upgrade the pom value <jenkins.version>2.249.1</jenkins.version> to a non LTS version.

[janfaracik]

this will need to upgrade the pom value <jenkins.version>2.249.1</jenkins.version> to a non LTS version.

Apologies, bit of a novice in this area. Is this still necessary if this PR still works/performs the same way on current LTS Jenkins?

[olamy]

this will need to upgrade the pom value <jenkins.version>2.249.1</jenkins.version> to a non LTS version.

Apologies, bit of a novice in this area. Is this still necessary if this PR still works/performs the same way on current LTS Jenkins?

no worries.
if this need too much unmaintainable code for a limited period of time not sure it worth it.
there are usually some rules https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
I can see some plugins are upgrading to some non LTS but depends what others contributors think about this.

[janfaracik]

this will need to upgrade the pom value <jenkins.version>2.249.1</jenkins.version> to a non LTS version.

Apologies, bit of a novice in this area. Is this still necessary if this PR still works/performs the same way on current LTS Jenkins?

no worries. if this need too much unmaintainable code for a limited period of time not sure it worth it. there are usually some rules https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ I can see some plugins are upgrading to some non LTS but depends what others contributors think about this.

Any thoughts on this @timja?

[timja]

@janfaracik Jenkins plugins use the version defined in the jenkins.version as the minimum version of Jenkins it's compatible with.

Historically maintainers did not like bumping it too high as people not up to date wouldn't get updates.
That's changed a bit in the last year or two, people seem to have decided that the people updating will get updates and critical fixes can always be backported to the old line.

Basically either you need to make sure it works on old versions of core and new versions.
Either by applying both stylings or version / feature detection

Or bump the minimum version up.

This plugin could certainly do with a minimum version bump but given how trivial it is to keep compatibility probably doesn't need to be done in this PR

[timja]

This change appears to be backwards and forwards compatible

Suggested change

	<select class="jenkins-select__input" name="durabilityHint">
	<!-- TODO Remove setting-input when baseline above 2.335 -->
	<select class="jenkins-select__input setting-input" name="durabilityHint">

[timja]

Thinking aloud is there not a tag built into Jenkins for this?

Why is this writing plain HTML ?

[timja]

see #205

[janfaracik]

see #205

#205 is infinitely better than mine - good job! I'll close this one.