Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-38635: Correct NodeParameterValue.jelly #45

Merged
merged 1 commit into from
Oct 19, 2017
Merged

JENKINS-38635: Correct NodeParameterValue.jelly #45

merged 1 commit into from
Oct 19, 2017

Conversation

ejpenney
Copy link
Contributor

@ejpenney ejpenney commented Jan 31, 2017

This change fixes JENKINS-38635 "NodeLabelParameter empty on rebuild of job initiated by Startup Trigger"

I've been unable to find any use cases that are broken by it.

@orgads
Copy link

orgads commented Jan 31, 2017

This fixed the issue for me too.

@ejpenney
Copy link
Contributor Author

ejpenney commented Feb 3, 2017

FYI, looks like the CloudBees' Jenkins job failed because the POM is still referencing old URLs. Looks like this works but is VERY slow, not sure what the maintainers want to do about that or if they want to leave it as is, but this change definitely works.

@GLundh
Copy link
Member

GLundh commented Oct 19, 2017

Please rebase from master. The repository URLs have been updated.

@GLundh GLundh merged commit f65f085 into jenkinsci:master Oct 19, 2017
@GLundh
Copy link
Member

GLundh commented Oct 19, 2017

I have verified locally. This seems to work fine. I'm merging and closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants