Fix for NodeLabel plugin #30
Conversation
|
It would be preferable to extend/use |
| Constructor ctor = oldValue.getClass().getConstructor(String.class, String.class); | ||
| return (ParameterValue)ctor.newInstance(new Object[]{oldValue.getName(), newValue}); | ||
| } catch (Exception e) { | ||
| } |
|
This should solve JENKINS-38635. Please merge it. |
| @@ -67,6 +68,7 @@ | |||
| public class RebuildAction implements Action { | |||
|
|
|||
| private static final String SVN_TAG_PARAM_CLASS = "hudson.scm.listtagsparameter.ListSubversionTagsParameterValue"; | |||
| private static final String NODE_LABEL_PARAM_CLASS = "org.jvnet.jenkins.plugins.nodelabelparameter.LabelParameterValue"; | |||
There was a problem hiding this comment.
there is also org.jvnet.jenkins.plugins.nodelabelparameter.NodeParameterValue, which extends org.jvnet.jenkins.plugins.nodelabelparameter.LabelParameterValue
|
👍 please merge it, it would make rebuild plugin useful for us again |
|
Actually I tried it and it didn't work. Did anyone else verify it? |
There was a problem hiding this comment.
🐛 since the fix is incomplete (see the comment from @imod). But I'm looking forward to get it fixed and released
|
Oh, too bad. @rsandell can you please have a look at this PR and change it so it can be merged finally? |
|
Not sure if this helps, but I noticed that changing this line in NodeParameterValue.jelly:
|
|
Well this actually not my change as it says in the description. I only uploaded the patch for the one who sent it to me and gave him the link hoping it wasn't a drive by contribution :'( |
|
No response for 8 days. Closing this one. |
Sent to me via mail