Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine darkmode and regular logo #263

Merged
merged 2 commits into from
Jun 3, 2023
Merged

Combine darkmode and regular logo #263

merged 2 commits into from
Jun 3, 2023

Conversation

pyatizbyantsevia
Copy link
Contributor

@pyatizbyantsevia pyatizbyantsevia commented Jun 3, 2023

All logic moved to logo.svg. Since the paths between the repositories to logo.svg are different, the working version can be viewed on the master branch of my fork
Closes #259

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@pyatizbyantsevia pyatizbyantsevia requested a review from a team as a code owner June 3, 2023 14:21
@pyatizbyantsevia pyatizbyantsevia changed the title Combine darkmode and regular logo (#259) Combine darkmode and regular logo Jun 3, 2023
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

Thanks so much for the PR! I'd recommend using switching the white for darkmode users, that matches with the symbol colors in Jenkins used for darkmode.

logo.svg Outdated Show resolved Hide resolved
Co-authored-by: Alexander Brandes <brandes.alexander@web.de>
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine darkmode and regular logo
2 participants