Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine darkmode and regular logo #259

Closed
NotMyFault opened this issue May 25, 2023 · 0 comments · Fixed by #263
Closed

Combine darkmode and regular logo #259

NotMyFault opened this issue May 25, 2023 · 0 comments · Fixed by #263

Comments

@NotMyFault
Copy link
Member

What feature do you want to see added?

Instead of having https://github.com/jenkinsci/design-library-plugin/blob/master/logo-dark.svg and https://github.com/jenkinsci/design-library-plugin/blob/master/logo.svg, we can make use of the prefers-color-scheme: dark attribute to apply colors, based on the theme the user requests.

Such a functionality allows using 1 image for multiple themes, like I did it with the header logo in https://github.com/jenkinsci/jenkins/blob/master/README.md

Upstream changes

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant