Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep node versions in sync #89

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Keep node versions in sync #89

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eba0264
Keep node versions in sync
NotMyFault Feb 11, 2024
37074b5
Remove dependabot.yml
NotMyFault Feb 11, 2024
29de130
Restore .tool-versions
NotMyFault Feb 11, 2024
93431e4
Update renovate.json
NotMyFault Feb 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions .github/dependabot.yml
View file
Open in desktop

This file was deleted.

17 changes: 17 additions & 0 deletions .github/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"config:base",
":semanticCommitsDisabled",
"schedule:monthly"
],
"regexManagers": [
{
"fileMatch": [".tool-versions"],
"matchStrings": ["nodejs (?<currentValue>.*?)\n"],
"depNameTemplate": "node",
"datasourceTemplate": "npm"
}
],
"rebaseWhen": "conflicted"
}
1 change: 0 additions & 1 deletion .nvmrc
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
lemeurherve marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 18.16.1
nodejs 21.6.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use an old version to check renovate works maybe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/NotMyFault/incrementals-publisher/issues/6

Applied this PR as patch NotMyFault@f9a1e7b and renovate detects it in its dashboard

Copy link
Member Author

@NotMyFault NotMyFault Feb 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I removed the regex check after renovate picked it up as asdf over regex in the issue linked above.

Copy link
Contributor

@dduportal dduportal Feb 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this possible to keep an LTS line to avoid bad surprises?

Nevermind, I see the 21 line is already used and we won't downgrade

2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:21
FROM node:21.6.1

ENV NODE_ENV production
ENV PORT 3000
Expand Down