Keep node versions in sync #89
Conversation
Signed-off-by: Alexander Brandes <mc.cache@web.de>
|
Maybe replace dependabot all together by renovabot at the same time? Dependabot annoyingly doesn't update version in comments, ex: https://github.com/jenkins-infra/incrementals-publisher/pull/79/files |
For sure! |
Signed-off-by: Alexander Brandes <mc.cache@web.de>
Signed-off-by: Alexander Brandes <mc.cache@web.de>
| @@ -1 +1 @@ | |||
| nodejs 18.16.1 | |||
| nodejs 21.6.1 | |||
There was a problem hiding this comment.
Use an old version to check renovate works maybe?
There was a problem hiding this comment.
https://github.com/NotMyFault/incrementals-publisher/issues/6
Applied this PR as patch NotMyFault@f9a1e7b and renovate detects it in its dashboard
There was a problem hiding this comment.
Actually, I removed the regex check after renovate picked it up as asdf over regex in the issue linked above.
There was a problem hiding this comment.
Is this possible to keep an LTS line to avoid bad surprises?
Nevermind, I see the 21 line is already used and we won't downgrade
Signed-off-by: Alexander Brandes <mc.cache@web.de>
|
I've requested an installation of renovate on this repo. |
|
Repo added: 
|
The change proposed switches to renovate to ensure the node version used to build on the CI and used in the Dockerfile remains aligned, see #73 diverging between the node versions.
Additionally, I removed the unused .nvmrc file, given 14 can't be used anyway.