Tolerate changelist.format=%d.v%s

[jglick]

Noticed in jenkinsci/jenkins-test-harness#277 that incremental deployment was not working, due to jenkinsci/incrementals-tools#19 breaking the assumption about the final version format. Amends #10 which was introduced for the previously recommended JEP-229 format.

[halkeye]

I feel like this would break tests, but I also don't see CI results being run.
looks like even if it was run, tests are not run inside the docker image

so /shrug

[jglick]

Indeed CI seems to be off. Running make locally…

[jglick]

Oh I see what you mean, that does not run tests. In abcdf72 you did not update README.md it seems: still says to make check.

I tried to

diff --git a/Dockerfile b/Dockerfile
index ef074ec..fab5076 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -17,4 +17,6 @@ RUN npm install
 # Bundle app source
 COPY . .
 
+RUN npm test
+
 CMD [ "node", "index.js" ]

but this complains something about Mocha.

[halkeye]

yea the docker file only runs npm install with NODE_ENV=production

I would say don't worry about it, if i get a min I'll make a multi stage docker image that runs tests first

[jglick]

Anyway, do you own this service? I apparently have write permissions to the repo but I should not be merging PRs.

[timja]

i assume this needs a version bump and a tag for release @halkeye ?

[halkeye]

yea, its the standard docker ci system, so bump version and generate tag and ci will take care of the rest

[jglick]

@halkeye @timja you know this is still not live, right? https://ci.jenkins.io/job/Core/job/jenkins-test-harness/job/PR-280/10/execution/node/32/log/

[timja]

updateCli was disabled for some reason, seems fixed now, PR is up at jenkins-infra/kubernetes-management#923