Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accommodate plugins defining a custom changelist.format #10

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Accommodate plugins defining a custom changelist.format #10

merged 1 commit into from
Sep 8, 2020

Conversation

jglick
Copy link
Collaborator

@jglick jglick commented Sep 8, 2020

@halkeye halkeye added the enhancement New feature or request label Sep 8, 2020
halkeye
halkeye approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@halkeye halkeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but lemme confirm the tests are calling this function

@halkeye
Copy link
Member

halkeye commented Sep 8, 2020

image

awesome

@halkeye halkeye merged commit 663d089 into jenkins-infra:master Sep 8, 2020
@halkeye
Copy link
Member

halkeye commented Sep 8, 2020

I'll try to do a release tonight after work, still polishing off the deploy workflow

@jglick jglick deleted the changelist.format branch September 8, 2020 18:27
@jglick
Copy link
Collaborator Author

jglick commented Sep 8, 2020

Thanks. No rush on this one.

@halkeye
Copy link
Member

halkeye commented Sep 9, 2020

Okay, builds are going though the pipeline, when https://incrementals.jenkins.io/liveness says 1.2.0 its live

@jglick jglick mentioned this pull request Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halkeye halkeye halkeye approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @halkeye