Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible with fzf #4

Closed
worldpotato opened this issue Jan 5, 2021 · 7 comments
Closed

incompatible with fzf #4

worldpotato opened this issue Jan 5, 2021 · 7 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@worldpotato
Copy link

First of all, let me say that it is a really nice plugin! Thank you!

But I found out that it is not compatible with some fzf features like the backward search. Which is really a bummer for me.

If I should provide some more infos like log files, my configuration etc. please let me know. I don't really know what could help you.

@jeffreytse jeffreytse self-assigned this Jan 5, 2021
@jeffreytse jeffreytse added the bug Something isn't working label Jan 5, 2021
@jeffreytse
Copy link
Owner

Hi @worldpotato

Firstly, so happy to heard that you love this plugin, this is my pleasure. Currently it's a really new plugin and I'm so sorry for that you met a compatible issue. And I will work to solve this problem, please be patient.

I will let you know if I need any more detail information about this issue. And welcome to star this project for updates and further features in the future.

Thanks and regards

@jeffreytse jeffreytse added the enhancement New feature or request label Jan 9, 2021
@jeffreytse
Copy link
Owner

jeffreytse commented Jan 9, 2021

Hi @worldpotato

Thanks for your patient. Since this plugin will overwrite the previous key bindings, this causes the fzf key bindings to fail. Currently this plugin has provided a mechanism to execute extra commands ( bb1857d ).

Now you have the below aspects for executing something:

zvm_before_init_commands=()
zvm_after_init_commands=()
zvm_before_select_vi_mode_commands=()
zvm_after_select_vi_mode_commands=()

You can solve the compatibility issue as below:

# Append a command directly
zvm_after_init_commands+=('[ -f ~/.fzf.zsh ] && source ~/.fzf.zsh')

or

# Define an init function and append to zvm_after_init_commands
function my_init() {
  [ -f ~/.fzf.zsh ] && source ~/.fzf.zsh
}
zvm_after_init_commands+=(my_init)

or

# The plugin will auto execute this zvm_after_init function
function zvm_after_init() {
  [ -f ~/.fzf.zsh ] && source ~/.fzf.zsh
}

Thanks and regards

@worldpotato
Copy link
Author

Wow!
Thank you very much for the patch!

Also a lot of thanks for the detailed explenation how to use it. Will try that later!

@BerkeleyTrue
Copy link

Works for me as well! Thanks for the quick response!

@jeffreytse
Copy link
Owner

jeffreytse commented Jan 10, 2021

Hi @worldpotato @BerkeleyTrue

🎉 Firstly, I hope your guys have a good day. And now I have a big good news for you.

The latest commit ( aad07d8 ) now has supported the lazy keybindings feature, and it is enabled by default, this feature will postpone some keybindings (i.e. normal/visual mode) to the first time you enter the normal mode. This feature can greatly improve the startup speed, it is faster almost 800% - 1000% than the last version.

I can tell you unceremoniously that the startup time on my machine took only 27ms, and before this it's almost 300ms. Hope you guys will like it.

Thanks and regards.

@BerkeleyTrue
Copy link

@worldpotato I think this issue can be closed

@worldpotato
Copy link
Author

@BerkeleyTrue Absolutly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants