Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with fzf-tab #114

Closed
3 tasks done
enricofadly opened this issue Jul 6, 2021 · 11 comments
Closed
3 tasks done

Incompatible with fzf-tab #114

enricofadly opened this issue Jul 6, 2021 · 11 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@enricofadly
Copy link

enricofadly commented Jul 6, 2021

General information

Basic examination

  • I have read through the README page
  • I have the latest version of zsh-vi-mode
  • I have tested with another terminal program

Problem description

I tried installed this zsh-vi-mode through the zimfw and manual but It make the fzf-tab become weird behaviour (the fzf-tab completion not working), I already tried #4 and still not working
fzf-tab not working

Zsh-vi-mode incompatible with fzf-tab ,

Reproduction steps

  1. Install through zimfw or manual sourcing
  2. put the zvm_after_init_commands+=('[ -f ~/.fzf.zsh ] && source ~/.fzf.zsh') on .zshrc
  3. tab completion not working after i installed it (i done the terminal restart too)

Expected behavior

This is the fzf-tab before i install the zsh-vi-mode
Expected fzf tab behaviour

@jeffreytse
Copy link
Owner

Hi @enricofadly

Can I confirm that the plugin you are talking about is Aloxaf/fzf-tab?

Thanks and regards

@enricofadly
Copy link
Author

Hi @enricofadly

Can I confirm that the plugin you are talking about is Aloxaf/fzf-tab?

Thanks and regards

Yes sir it is,

and thanks for making this amazing software, I just hope it would work with fzf-tab too

@jeffreytse
Copy link
Owner

@enricofadly , you're welcome. Also thanks for your support to this plugin. Welcome to star this project for further updates in the future. I will try to settle this issue as soon as possible.

@jeffreytse jeffreytse added the good first issue Good for newcomers label Jul 6, 2021
@jeffreytse jeffreytse self-assigned this Jul 6, 2021
@roosta
Copy link

roosta commented Jul 6, 2021

Just wanna chime in with the unhelpful comment "it works here". I use zplug instead of zimfw to manage my plugins, other than that I don't really have anything special in my config. I recall having some issues with load order with some plugins, but when I tried moving fzf-tab, it still worked fine. Other than that I got nothing, but I would maybe start looking at zimfw.

@enricofadly
Copy link
Author

@enricofadly , you're welcome. Also thanks for your support to this plugin. Welcome to star this project for further updates in the future. I will try to settle this issue as soon as possible.

Ok sir, glad to know ur working on this, i already starred it tho, thanks sir

@enricofadly
Copy link
Author

Just wanna chime in with the unhelpful comment "it works here". I use zplug instead of zimfw to manage my plugins, other than that I don't really have anything special in my config. I recall having some issues with load order with some plugins, but when I tried moving fzf-tab, it still worked fine. Other than that I got nothing, but I would maybe start looking at zimfw.

Glad to know it could still work with fzf-tab, im looking around the zplug might be found something useful,

Thanks for letting me know this sir

@jeffreytse
Copy link
Owner

jeffreytse commented Jul 6, 2021

@enricofadly I just have a test on the fzf-tab within zinit plugin manager, it totally works well without the issue you mentioned.

@enricofadly
Copy link
Author

@enricofadly I just have a test on the fzf-tab within zinit plugin manager, it totally works well without the issue you mentioned.

Ok sir that cleared half the issue that its not on fzftab and zsh vi mode issue, ill try issue the zimfw then, thanks sir for ur working and i close this issue,

Thanks a lot

@jeffreytse
Copy link
Owner

Hi @enricofadly

Here is the solution to make fzf-tab work within zimfw:

  1. Add zmodule Aloxaf/fzf-tab to your .zimrc
  2. Add zvm_after_init+=('source ${ZIM_HOME}/modules/fzf-tab/fzf-tab.zsh') to your .zshrc
  3. Restart your terminal

Hope you have a good experience!

Thanks and regards

@enricofadly
Copy link
Author

Hi @enricofadly

Here is the solution to make fzf-tab work within zimfw:

  1. Add zmodule Aloxaf/fzf-tab to your .zimrc
  2. Add zvm_after_init+=('source ${ZIM_HOME}/modules/fzf-tab/fzf-tab.zsh') to your .zshrc
  3. Restart your terminal

Hope you have a good experience!

Thanks and regards

aye aye sir that's working sir.
thanks so much sir and thanks to put effort to fix my problem sir I hope this project get bigger and bigger sir

@cathaysia
Copy link

cathaysia commented Aug 12, 2021

This issuse can be fixed by zinit's turbo mode. Here is a way to fix this: https://github.com/zdharma/history-search-multi-word/issues/19#issuecomment-897427291

Here is my configuration:

zinit ice silent wait '!0'
zinit snippet https://github.com/junegunn/fzf/blob/d4ed955aee08a1c2ceb64e562ab4a88bdc9af8f0/shell/completion.zsh
zinit ice silent wait '!0'
zinit snippet https://github.com/junegunn/fzf/blob/d4ed955aee08a1c2ceb64e562ab4a88bdc9af8f0/shell/key-bindings.zsh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants