Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): deprecation warnings and others #84

Merged
merged 4 commits into from
May 6, 2024
Merged

fix(lib): deprecation warnings and others #84

merged 4 commits into from
May 6, 2024

Conversation

jeertmans
Copy link
Owner

No description provided.

@jeertmans jeertmans added the bug Something isn't working label May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

Rust benchmark results:

group                                                       before                                 changes
-----                                                       ------                                 -------
complete_graph_all_paths/iter                               1.02     23.6±0.18ns 40.5 MElem/sec    1.00     23.2±0.45ns 41.1 MElem/sec
complete_graph_all_paths_array_chunks/1                     1.02     33.4±0.45ns 28.6 MElem/sec    1.00     32.6±0.42ns 29.3 MElem/sec
complete_graph_all_paths_array_chunks/10                    1.00    356.8±2.65ns 26.7 MElem/sec    1.00   357.5±20.30ns 26.7 MElem/sec
complete_graph_all_paths_array_chunks/100                   1.00      2.4±0.04µs 39.2 MElem/sec    1.01      2.5±0.02µs 38.8 MElem/sec
complete_graph_all_paths_array_chunks/1000                  1.00     22.4±0.39µs 42.5 MElem/sec    1.01     22.6±0.91µs 42.2 MElem/sec
di_graph_from_complete_graph_all_paths/iter                 1.00    236.0±3.80ns  4.0 MElem/sec    1.04    246.2±5.39ns  3.9 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1       1.01    247.4±4.43ns  3.9 MElem/sec    1.00    245.7±4.36ns  3.9 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/10      1.00      2.7±0.02µs  3.6 MElem/sec    1.03      2.8±0.02µs  3.5 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/100     1.00     24.2±0.29µs  3.9 MElem/sec    1.01     24.4±0.23µs  3.9 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1000    1.00    228.7±2.37µs  4.2 MElem/sec    1.02    232.2±1.84µs  4.1 MElem/sec

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (8201591) to head (a4c95af).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   88.81%   90.57%   +1.75%     
==========================================
  Files          35       35              
  Lines        1252     1252              
==========================================
+ Hits         1112     1134      +22     
+ Misses        140      118      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 6, 2024

Python benchmark results:


-------------------------------- benchmark 'complete_graph_all_paths': 3 tests --------------------------------
Name (time in ns)                                    Mean              StdDev            OPS (Mops/s)          
---------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths (0002_pgo)         327.1770 (1.0)       31.7776 (1.0)            3.0564 (1.0)    
test_complete_graph_all_paths (0001_changes)     344.1607 (1.05)     143.3435 (4.51)           2.9056 (0.95)   
test_complete_graph_all_paths (0003_before)      350.7254 (1.07)     254.5363 (8.01)           2.8512 (0.93)   
---------------------------------------------------------------------------------------------------------------

----------------------------------- benchmark 'complete_graph_all_paths_array_chunks': 12 tests ------------------------------------
Name (time in ns)                                                       Mean                StdDev            OPS (Mops/s)          
------------------------------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths_array_chunks[1000] (0002_pgo)          28.7023 (1.0)        204.1296 (1.72)          34.8404 (1.0)    
test_complete_graph_all_paths_array_chunks[1000] (0001_changes)      31.6652 (1.10)       182.3411 (1.53)          31.5805 (0.91)   
test_complete_graph_all_paths_array_chunks[1000] (0003_before)       30.5902 (1.07)       128.3117 (1.08)          32.6902 (0.94)   
test_complete_graph_all_paths_array_chunks[100] (0002_pgo)           36.3180 (1.27)       118.8055 (1.0)           27.5345 (0.79)   
test_complete_graph_all_paths_array_chunks[100] (0003_before)        40.2413 (1.40)       276.0253 (2.32)          24.8501 (0.71)   
test_complete_graph_all_paths_array_chunks[100] (0001_changes)       40.0734 (1.40)       231.3546 (1.95)          24.9542 (0.72)   
test_complete_graph_all_paths_array_chunks[10] (0002_pgo)            76.9059 (2.68)       164.2464 (1.38)          13.0029 (0.37)   
test_complete_graph_all_paths_array_chunks[10] (0001_changes)        76.9326 (2.68)       235.4463 (1.98)          12.9984 (0.37)   
test_complete_graph_all_paths_array_chunks[10] (0003_before)         77.9434 (2.72)       251.8006 (2.12)          12.8298 (0.37)   
test_complete_graph_all_paths_array_chunks[1] (0003_before)         360.6658 (12.57)    1,723.7684 (14.51)          2.7726 (0.08)   
test_complete_graph_all_paths_array_chunks[1] (0002_pgo)            350.9552 (12.23)      566.5606 (4.77)           2.8494 (0.08)   
test_complete_graph_all_paths_array_chunks[1] (0001_changes)        364.1712 (12.69)    1,033.7199 (8.70)           2.7460 (0.08)   
------------------------------------------------------------------------------------------------------------------------------------

------------------------------------- benchmark 'di_graph_complete_graph_all_paths_array_chunks': 12 tests -------------------------------------
Name (time in ns)                                                                     Mean              StdDev            OPS (Mops/s)          
------------------------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0002_pgo)          256.3386 (1.07)      25.3058 (3.24)           3.9011 (0.94)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0002_pgo)         240.1846 (1.0)        7.9647 (1.02)           4.1635 (1.0)    
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0001_changes)      264.0685 (1.10)      31.5337 (4.04)           3.7869 (0.91)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0003_before)      258.3397 (1.08)       8.7827 (1.12)           3.8709 (0.93)   
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0003_before)       273.1611 (1.14)      25.5664 (3.27)           3.6608 (0.88)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0001_changes)     254.2686 (1.06)       7.8126 (1.0)            3.9328 (0.94)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0002_pgo)           310.2211 (1.29)     154.2041 (19.74)          3.2235 (0.77)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0003_before)        336.3865 (1.40)     170.0045 (21.76)          2.9728 (0.71)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0001_changes)       335.6016 (1.40)     196.3435 (25.13)          2.9797 (0.72)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0002_pgo)            571.4481 (2.38)     577.6291 (73.94)          1.7499 (0.42)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0001_changes)        605.5349 (2.52)     930.1652 (119.06)         1.6514 (0.40)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0003_before)         614.2013 (2.56)     868.2942 (111.14)         1.6281 (0.39)   
------------------------------------------------------------------------------------------------------------------------------------------------

--------------------------------- benchmark 'di_graph_from_complete_graph_all_paths': 3 tests ---------------------------------
Name (time in ns)                                                  Mean                StdDev            OPS (Mops/s)          
-------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths (0001_changes)     587.2673 (1.0)        652.6322 (1.12)           1.7028 (1.0)    
test_di_graph_from_complete_graph_all_paths (0002_pgo)         593.9233 (1.01)       583.2149 (1.0)            1.6837 (0.99)   
test_di_graph_from_complete_graph_all_paths (0003_before)      597.2384 (1.02)     1,141.1522 (1.96)           1.6744 (0.98)   
-------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

@jeertmans jeertmans merged commit e5dc280 into main May 6, 2024
43 of 47 checks passed
@jeertmans jeertmans deleted the fixes branch May 6, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant