Skip to content

Commit

Permalink
fix(lib): deprecation warnings and others (#84)
Browse files Browse the repository at this point in the history
* fix(lib): deprecation warning

* fix(ci): codecov

* fix(ci): path to wheels

* fix(ci): correct pip install
  • Loading branch information
jeertmans authored May 6, 2024
1 parent 8201591 commit e5dc280
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 12 deletions.
13 changes: 6 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,18 +69,17 @@ jobs:
- name: Run Pytest
if: matrix.os != 'ubuntu-latest' || matrix.pyversion != '3.12'
shell: bash
run: |
rye run pytest -n auto
run: rye run pytest -n auto

- name: Run pytest and coverage for differt
if: matrix.os == 'ubuntu-latest' && matrix.pyversion == '3.12'
run: rye run pytest --cov-report xml --cov=differt differt/tests/
run: rye run pytest --cov-report xml --cov=differt differt

- name: Upload to codecov.io
if: matrix.os == 'ubuntu-latest' && matrix.pyversion == '3.12'
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
token: ${{ secrets.DIFFERT_CODECOV_TOKEN }}
fail_ci_if_error: true

cargo-test:
Expand Down Expand Up @@ -150,7 +149,7 @@ jobs:
- name: Generate profile data
run: |
python -m ensurepip
python -m pip install differt --no-index --no-deps --find-links pgo-wheel --force-reinstall
python -m pip install differt-core --no-index --no-deps --find-links differt-core/pgo-wheel --force-reinstall
pytest --benchmark-only differt-core/tests/benchmarks
rustup run stable bash -c 'echo LLVM_PROFDATA=$RUSTUP_HOME/toolchains/$RUSTUP_TOOLCHAIN/lib/rustlib/${{ env.RUST_HOST }}/bin/llvm-profdata >> "$GITHUB_ENV"'
Expand All @@ -169,7 +168,7 @@ jobs:

- name: Run Benchmarks on changes with PGO-optimized wheel
run: |
python -m pip install differt --no-index --no-deps --find-links opt-wheel --force-reinstall
python -m pip install differt-core --no-index --no-deps --find-links differt-core/opt-wheel --force-reinstall
pytest --benchmark-only --benchmark-save=pgo differt-core/tests/benchmarks
- name: Checkout base branch
Expand All @@ -191,7 +190,7 @@ jobs:

- name: Run Benchmarks before changes
run: |
python -m pip install differt --no-index --no-deps --find-links dist --force-reinstall
python -m pip install differt-core --no-index --no-deps --find-links differt-core/dist --force-reinstall
pytest --benchmark-only --benchmark-save=before differt-core/tests/benchmarks
- name: Compare benchmarks
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,5 +120,5 @@ pytest --benchmark-only
[pypi-python-version-badge]: https://img.shields.io/pypi/pyversions/DiffeRT?color=orange
[documentation-badge]: https://readthedocs.org/projects/differt/badge/?version=latest
[documentation-url]: https://differt.readthedocs.io/latest/?badge=latest
[codecov-badge]: https://codecov.io/gh/jeertmans/DiffeRT/branch/main/graph/badge.svg?token=8P4DY9JCE4
[codecov-badge]: https://codecov.io/gh/jeertmans/DiffeRT/branch/main/graph/badge.svg?token=v63alnTWzu
[codecov-url]: https://codecov.io/gh/jeertmans/DiffeRT
3 changes: 0 additions & 3 deletions differt-core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
[![Latest Release][pypi-version-badge]][pypi-version-url]
[![Python version][pypi-python-version-badge]][pypi-version-url]
[![Documentation][documentation-badge]][documentation-url]
[![Codecov][codecov-badge]][codecov-url]

</div>

Expand All @@ -32,5 +31,3 @@ are shared with the
[pypi-python-version-badge]: https://img.shields.io/pypi/pyversions/DiffeRT-core?color=orange
[documentation-badge]: https://readthedocs.org/projects/differt/badge/?version=latest
[documentation-url]: https://differt.readthedocs.io/latest/?badge=latest
[codecov-badge]: https://codecov.io/gh/jeertmans/DiffeRT-core/branch/main/graph/badge.svg?token=8P4DY9JCE4
[codecov-url]: https://codecov.io/gh/jeertmans/DiffeRT-core
2 changes: 1 addition & 1 deletion differt/src/differt/scene/sionna.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def members(tar: tarfile.TarFile):
f.flush()

with tarfile.open(f.name) as tar:
tar.extractall(path=folder, members=members(tar))
tar.extractall(path=folder, members=members(tar), filter="data")


def list_sionna_scenes(*, folder: Union[str, Path] = SIONNA_SCENES_FOLDER) -> list[str]:
Expand Down

0 comments on commit e5dc280

Please sign in to comment.